Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable prebuilt model #682

Merged
merged 2 commits into from
Jan 10, 2023
Merged

disable prebuilt model #682

merged 2 commits into from
Jan 10, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Signed-off-by: Yaliang Wu ylwu@amazon.com

Description

We need security review model first. We don't have enough time for that. So disable prebuilt model for 2.5.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team January 10, 2023 05:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #682 (2bbb422) into 2.x (04d6864) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                2.x     #682      +/-   ##
============================================
- Coverage     84.18%   83.96%   -0.22%     
+ Complexity     1010     1008       -2     
============================================
  Files            93       93              
  Lines          3660     3660              
  Branches        342      342              
============================================
- Hits           3081     3073       -8     
- Misses          435      443       +8     
  Partials        144      144              
Flag Coverage Δ
ml-commons 83.96% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/org/opensearch/ml/model/MLModelManager.java 78.20% <0.00%> (ø)
...ain/java/org/opensearch/ml/task/MLTaskManager.java 61.92% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn merged commit bbe6ef8 into opensearch-project:2.x Jan 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit bbe6ef8)
ylwu-amzn added a commit that referenced this pull request Jan 10, 2023
* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit bbe6ef8)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ryanbogan pushed a commit to ryanbogan/ml-commons that referenced this pull request Jan 10, 2023
* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@b4sjoo b4sjoo added the feature label Jan 10, 2023
b4sjoo pushed a commit that referenced this pull request Jan 10, 2023
…now coming from core (#652)" (#684)

* disable prebuilt model (#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 10, 2023
…now coming from core (#652)" (#684)

* disable prebuilt model (#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
(cherry picked from commit d169568)
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684)

* disable prebuilt model (opensearch-project#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn mentioned this pull request Feb 17, 2023
5 tasks
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 2, 2023
* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit that referenced this pull request Mar 2, 2023
* disable prebuilt model



* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 2, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684)

* disable prebuilt model (opensearch-project#682)

* disable prebuilt model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add volatile for trusted url regex

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>

* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)"

This reverts commit 26435de.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn added a commit that referenced this pull request Mar 2, 2023
…now coming from core (#652)" (#684) (#774)

* disable prebuilt model (#682)

* disable prebuilt model



* add volatile for trusted url regex






* Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)"

This reverts commit 26435de.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Co-authored-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants