-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable prebuilt model #682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #682 +/- ##
============================================
- Coverage 84.18% 83.96% -0.22%
+ Complexity 1010 1008 -2
============================================
Files 93 93
Lines 3660 3660
Branches 342 342
============================================
- Hits 3081 3073 -8
- Misses 435 443 +8
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
b4sjoo
approved these changes
Jan 10, 2023
jngz-es
approved these changes
Jan 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
* disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit bbe6ef8)
ylwu-amzn
added a commit
that referenced
this pull request
Jan 10, 2023
* disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit bbe6ef8) Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ryanbogan
pushed a commit
to ryanbogan/ml-commons
that referenced
this pull request
Jan 10, 2023
* disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com>
b4sjoo
pushed a commit
that referenced
this pull request
Jan 10, 2023
…now coming from core (#652)" (#684) * disable prebuilt model (#682) * disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
…now coming from core (#652)" (#684) * disable prebuilt model (#682) * disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit d169568)
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
* disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684) * disable prebuilt model (opensearch-project#682) * disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
* disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Mar 2, 2023
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684) * disable prebuilt model (opensearch-project#682) * disable prebuilt model Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
added a commit
that referenced
this pull request
Mar 2, 2023
…now coming from core (#652)" (#684) (#774) * disable prebuilt model (#682) * disable prebuilt model * add volatile for trusted url regex * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Co-authored-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
We need security review model first. We don't have enough time for that. So disable prebuilt model for 2.5.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.