address comments

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
opensearch-project · Feb 17, 2023 · 444228f · 444228f
1 parent 334cb77
commit 444228f
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/common/src/main/java/org/opensearch/ml/common/transport/upload/MLUploadInput.java b/common/src/main/java/org/opensearch/ml/common/transport/upload/MLUploadInput.java
@@ -73,18 +73,14 @@ public MLUploadInput(FunctionName functionName,
         if (version == null) {
             throw new IllegalArgumentException("model version is null");
         }
-        //TODO: enable prebuilt model in 2.6
+        if (modelFormat == null) {
+            throw new IllegalArgumentException("model format is null");
+        }
         if (url != null) {
-            if (modelFormat == null) {
-                throw new IllegalArgumentException("model format is null");
-            }
             if (modelConfig == null) {
                 throw new IllegalArgumentException("model config is null");
             }
         }
-        if (modelFormat == null) {
-            throw new IllegalArgumentException("model format is null");
-        }
         this.modelName = modelName;
         this.version = version;
         this.description = description;