Moved remote index build client to a separate module #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7799c3 to
b4d7e3c
Compare
Signed-off-by: Navneet Verma <navneev@amazon.com>
jed326
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Thanks @navneet1v , changes LGTM but had one discussion point
Comment on lines
-396
to
+399
| RemoteIndexHTTPClient.reloadAuthHeader(settings); | ||
| SecureString username = KNNSettings.KNN_REMOTE_BUILD_CLIENT_USERNAME_SETTING.get(settings); | ||
| SecureString password = KNNSettings.KNN_REMOTE_BUILD_CLIENT_PASSWORD_SETTING.get(settings); | ||
| RemoteIndexHTTPClient.reloadAuthHeader(username, password); |
There was a problem hiding this comment.
Thinking out loud here, should we go one step further and define the client as it's own plugin?
There was a problem hiding this comment.
This is very interesting thought. the reason of having this as a plugin is because we have like repository-s3 plugin, azure plugin which does similar things which is providing abstraction over s3, azure store
|
Also I lean towards pulling this in after #2576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved remote index build client to a separate module
Next steps:
Add few tests which are removed.
Related Issues
NA
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.