Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K-NN Plugin Upgrade with Lucene 10.0.1 #2429

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Vikasht34
Copy link
Collaborator

@Vikasht34 Vikasht34 commented Jan 23, 2025

Description

As per Lucene 10.0.1 upgrade, There are lots of breaking changes. This PR consumes Lucene 10.0.1 as part of Opensearch 3.0.0 snapshot and Fixes all breaking changes.

Note :- This PR Does not aim to refactor any part of code, It's just making compatible with Lucene 10.0.1

Resolves this issues

#2434
#2433

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski
Copy link
Member

it looks like opensearch-knn-test-fixtures needs to consume latest corre main with lucene 10

/home/runner/work/k-NN/k-NN/src/main/java/org/opensearch/knn/index/codec/KNNCodecVersion.java:16: error: package org.apache.lucene.backward_codecs.lucene912 does not exist
import org.apache.lucene.backward_codecs.lucene912.Lucene912Codec;

@Vikasht34
Copy link
Collaborator Author

it looks like opensearch-knn-test-fixtures needs to consume latest corre main with lucene 10

/home/runner/work/k-NN/k-NN/src/main/java/org/opensearch/knn/index/codec/KNNCodecVersion.java:16: error: package org.apache.lucene.backward_codecs.lucene912 does not exist
import org.apache.lucene.backward_codecs.lucene912.Lucene912Codec;

Yes ...Agree ...We need to change to alpha !! lots of things started breaking ..This Pr would be updated with all latest changes.

@Vikasht34 Vikasht34 marked this pull request as draft January 24, 2025 21:49
@Vikasht34 Vikasht34 force-pushed the CodecFix branch 8 times, most recently from 934094b to e0f283e Compare February 1, 2025 23:19
@Vikasht34 Vikasht34 changed the title Fixing Lucene912Codec Issue with BWC for Lucene 10.0.1 upgrade K-NN Plugin Upgrade with Lucene 10.0.1 Feb 2, 2025
@Vikasht34 Vikasht34 deleted the CodecFix branch February 6, 2025 18:21
This was referenced Feb 10, 2025
Vikasht34 added a commit to Vikasht34/k-NN that referenced this pull request Feb 12, 2025
Signed-off-by: Vikasht34 <viktari@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants