Use pluginSubject for system index interaction and remove usages of stashContext #714
+103
−33
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| */ | ||
| package org.opensearch.jobscheduler.transport; | ||
|
|
||
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| import org.opensearch.action.ActionRequest; | ||
| import org.opensearch.action.ActionType; | ||
| import org.opensearch.client.Client; | ||
| import org.opensearch.client.FilterClient; | ||
| import org.opensearch.common.util.concurrent.ThreadContext; | ||
| import org.opensearch.core.action.ActionListener; | ||
| import org.opensearch.core.action.ActionResponse; | ||
| import org.opensearch.identity.Subject; | ||
|
|
||
| /** | ||
| * Implementation of client that will run transport actions in a stashed context and inject the name of the provided | ||
| * subject into the context. | ||
| */ | ||
| public class RunAsSubjectClient extends FilterClient { | ||
|
|
||
| private static final Logger logger = LogManager.getLogger(RunAsSubjectClient.class); | ||
|
|
||
| private Subject subject; | ||
|
|
||
| public RunAsSubjectClient(Client delegate) { | ||
| super(delegate); | ||
| } | ||
|
|
||
| public RunAsSubjectClient(Client delegate, Subject subject) { | ||
| super(delegate); | ||
| this.subject = subject; | ||
| } | ||
|
|
||
| public void setSubject(Subject subject) { | ||
| this.subject = subject; | ||
| } | ||
|
|
||
| @Override | ||
| protected <Request extends ActionRequest, Response extends ActionResponse> void doExecute( | ||
| ActionType<Response> action, | ||
| Request request, | ||
| ActionListener<Response> listener | ||
| ) { | ||
| if (subject == null) { | ||
| throw new IllegalStateException("RunAsSubjectClient is not initialized."); | ||
| } | ||
| try (ThreadContext.StoredContext ctx = threadPool().getThreadContext().newStoredContext(false)) { | ||
| subject.runAs(() -> { | ||
| logger.info("Running transport action with subject: {}", subject.getPrincipal().getName()); | ||
| super.doExecute(action, request, ActionListener.runBefore(listener, ctx::restore)); | ||
| return null; | ||
| }); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is necessary here just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to resolve a race condition discovered in GetLockMultiNodeRestIT.testGetLockRestAPI. This test will create and release a lock 10 times in a loop. Without adding this RefreshPolicy, when the security plugin is installed it can fail to find the lock the was just created. By setting this RefreshPolicy to IMMEDIATE, we can guarantee that this newly created document is available for search (including GET actions)