-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Rest Integ Tests with the Security plugin installed #645
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@prudhvigodithi I switched this to ready for review to start soliciting feedback, but I am still working on a change to remove duplication between the SPI and the sample-extension-plugin which both perform integ tests and have some classes in common. I was able to create a separate sourceSet with common test classes, but had some trouble bundling the resources like the certificates. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
=========================================
Coverage 37.67% 37.67%
Complexity 135 135
=========================================
Files 22 22
Lines 1189 1189
Branches 109 109
=========================================
Hits 448 448
Misses 704 704
Partials 37 37 ☔ View full report in Codecov by Sentry. |
Thanks @cwperks LGTM. |
I just noticed that the new workflow is named |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/job-scheduler/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/job-scheduler/backport-2.x
# Create a new branch
git switch --create backport/backport-645-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f1ad8650ceb5616ff85808307a4350f13b86e667
# Push it to GitHub
git push --set-upstream origin backport/backport-645-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/job-scheduler/backport-2.x Then, create a pull request where the |
#645) (#712) * Run Rest Integ Tests with the Security plugin installed (#645) * Make .opendistro-job-scheduler-lock a System Index Signed-off-by: Craig Perkins <cwperx@amazon.com> * Switch back to private Signed-off-by: Craig Perkins <cwperx@amazon.com> * WIP on writing a CI check with security installed Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add CI Check to run Rest IntegTests with Security Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fake settings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Configure https client for sample extension plugin Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix forbidden apis Signed-off-by: Craig Perkins <cwperx@amazon.com> * spotlessApply Signed-off-by: Craig Perkins <cwperx@amazon.com> * Uncomment lint Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove settings Signed-off-by: Craig Perkins <cwperx@amazon.com> * JDK 21 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add sample-extension-plugin/build.gradle to version bump Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove duplicate changes in sample plugin build.gradle Signed-off-by: Craig Perkins <cwperx@amazon.com> * remove other changes in sample plugin build.gradle Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit f1ad865) * Use PathUtils.get Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
Opening up a Draft PR to start soliciting feedback. The goal of this PR is to run integ tests in this repo with the security plugin installed. This PR is a step towards being able to add tests for #347.
With the change in this PR you can run the
sample-extension-plugin
with security using./gradlew :opensearch-job-scheduler-sample-extension:run -Dsecurity=true -Dhttps=true -Dtests.opensearch.username=admin -Dtests.opensearch.password=admin -x integTest
And run integTest with security like:
Example response to CAT plugins
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.