Fixing Strings import #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
saratvemulapalli
approved these changes
Aug 8, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #459 +/- ##
=========================================
Coverage 29.19% 29.19%
Complexity 98 98
=========================================
Files 22 22
Lines 1185 1185
Branches 109 109
=========================================
Hits 346 346
Misses 818 818
Partials 21 21 |
smortex
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
LGTM!
This seems to be the first plugin preventing daily distribution builds on https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/activity/
Hailong-am
approved these changes
Aug 9, 2023
cwperks
approved these changes
Aug 9, 2023
vibrantvarun
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing Strings issue due to changes upstream
Issues Resolved
#454
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.