Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring spotlessApply for Job Scheduler #290

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Configuring spotlessApply for Job Scheduler #290

merged 3 commits into from
Dec 29, 2022

Conversation

joshpalis
Copy link
Member

Description

Adds spotlessApply for Job Scheduler

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #290 (80310b0) into main (7727871) will decrease coverage by 0.85%.
The diff coverage is 25.55%.

@@             Coverage Diff              @@
##               main     #290      +/-   ##
============================================
- Coverage     53.19%   52.33%   -0.86%     
  Complexity       65       65              
============================================
  Files             8        8              
  Lines           438      449      +11     
  Branches         50       50              
============================================
+ Hits            233      235       +2     
- Misses          186      195       +9     
  Partials         19       19              
Impacted Files Coverage Δ
...rg/opensearch/jobscheduler/JobSchedulerPlugin.java 36.53% <0.00%> (-0.72%) ⬇️
.../opensearch/jobscheduler/JobSchedulerSettings.java 85.71% <ø> (ø)
.../opensearch/jobscheduler/ScheduledJobProvider.java 80.00% <ø> (ø)
...arch/jobscheduler/scheduler/JobSchedulingInfo.java 79.16% <ø> (ø)
...rg/opensearch/jobscheduler/sweeper/JobSweeper.java 39.49% <20.58%> (-0.77%) ⬇️
...earch/jobscheduler/scheduler/ScheduledJobInfo.java 80.00% <40.00%> (ø)
...pensearch/jobscheduler/scheduler/JobScheduler.java 72.72% <50.00%> (-1.40%) ⬇️
...cheduler/LegacyOpenDistroJobSchedulerSettings.java 90.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but suggest you add ./gradlew spotlessCheck to the CI.

Also unrelated to this PR, I don't think the DCO workflow is required any more as the DCO App is installed org-wide.

@saratvemulapalli saratvemulapalli merged commit 140ffd3 into opensearch-project:main Dec 29, 2022
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-290-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 140ffd3d48f928db78fa9fb23242e8b50282f7aa
# Push it to GitHub
git push --set-upstream origin backport/backport-290-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-290-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants