Backport Issue #998 #1067
Merged
Backport Issue #998 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added filtering on query and metadata map Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed github workflow check errors Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed debugging comments Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Updated code styling to make more clear Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Refactored code to match suggestions Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added test case for the ExplainFilter.byMetaData and parse methods Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Started implementation of explain filter IT Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Implemented test explain filter method Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Implemented explain filter test on failure Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Cleaned up log statements Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added explain filter test for success Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed lint errors Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed policy from index to fix flaky tests Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added filtering on query and metadata map Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed github workflow check errors Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed debugging comments Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Updated code styling to make more clear Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Refactored code to match suggestions Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
* Implemented filtering on the ISM eplain API Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed tests for ExplainRequest Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added filtering on query and metadata map Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Filtered on indexNames in metadata Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed github workflow check errors Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed debugging comments Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Updated code styling to make more clear Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Refactored code to match suggestions Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added test case for the ExplainFilter.byMetaData and parse methods Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Started implementation of explain filter IT Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Implemented test explain filter method Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Implemented explain filter test on failure Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Cleaned up log statements Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added explain filter test for success Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed lint errors Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed policy from index to fix flaky tests Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1067 +/- ##
============================================
+ Coverage 74.93% 75.04% +0.10%
- Complexity 2873 2899 +26
============================================
Files 371 372 +1
Lines 17030 17118 +88
Branches 2454 2473 +19
============================================
+ Hits 12762 12846 +84
- Misses 2898 2900 +2
- Partials 1370 1372 +2 ☔ View full report in Codecov by Sentry. |
bowenlan-amzn
approved these changes
Dec 31, 2023
jowg-amazon
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Backport the explain filter feature implementation and its tests
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.