Added unit tests with some refactoring of codes

[heemin32]

Description

Added unit tests with some refactoring of codes

• Add Unit tests
• Set cache true for search query
• Remove in memory cache implementation (Two way door decision)
  • Relying on search cache without custom cache
• Renamed datasource state from FAILED to CREATE_FAILED

Issues Resolved

N/A

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #271 (62e5882) into feature/ip2geo (4b29b4e) will increase coverage by 26.21%.
The diff coverage is 81.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                  Coverage Diff                  @@
##             feature/ip2geo     #271       +/-   ##
=====================================================
+ Coverage             60.09%   86.31%   +26.21%     
- Complexity              424      544      +120     
=====================================================
  Files                    67       67               
  Lines                  2065     2038       -27     
  Branches                187      180        -7     
=====================================================
+ Hits                   1241     1759      +518     
+ Misses                  777      206      -571     
- Partials                 47       73       +26     

Impacted Files	Coverage Δ
...atial/ip2geo/jobscheduler/DatasourceExtension.java	100.00% <ø> (+100.00%)	⬆️
...rch/geospatial/ip2geo/jobscheduler/Datasource.java	93.92% <53.84%> (+52.59%)	⬆️
...ospatial/ip2geo/jobscheduler/DatasourceRunner.java	69.23% <57.14%> (+69.23%)	⬆️
...arch/geospatial/ip2geo/common/GeoIpDataFacade.java	80.14% <80.64%> (ø)
...h/geospatial/ip2geo/processor/Ip2GeoProcessor.java	84.21% <84.84%> (+78.98%)	⬆️
...al/ip2geo/action/PutDatasourceTransportAction.java	86.04% <85.71%> (+86.04%)	⬆️
...l/ip2geo/jobscheduler/DatasourceUpdateService.java	85.71% <85.71%> (ø)
...geospatial/ip2geo/action/PutDatasourceRequest.java	98.27% <87.50%> (+49.15%)	⬆️
...patial/ip2geo/action/RestPutDatasourceHandler.java	93.33% <100.00%> (+43.33%)	⬆️
...rch/geospatial/ip2geo/common/DatasourceFacade.java	89.47% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

[heemin32]

Discussed offline with @jmazanec15. He made a good point that I should not register setting update in processor constructor which does not deregister itself when it is deleted. Will resolve the issue.

[heemin32]

@jmazanec15 @VijayanB Can I get another round of look at this PR?

[VijayanB]

nit: getHeadersIfValid

[heemin32]

getHeadersIfValid doesn't sounds right. Changed it as

CSVRecord headerLine = reader.iterator().next();
header = validateHeader(headerLine).values();

private CSVRecord validateHeader(CSVRecord header) {
    if (header == null) {
        throw new OpenSearchException("geoip database is empty");
    }
    if (header.values().length < 2) {
        throw new OpenSearchException("geoip database should have at least two fields");
    }
    return header;
}

[heemin32]

@VijayanB @jmazanec15 Any more comments?

[jmazanec15]

LGTM