Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
============================================
- Coverage 78.09% 78.07% -0.02%
- Complexity 995 996 +1
============================================
Files 99 99
Lines 4624 4625 +1
Branches 431 431
============================================
Hits 3611 3611
- Misses 833 834 +1
Partials 180 180 ☔ View full report in Codecov by Sentry. |
…ovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com>
2f0b9ee to
b321f76
Compare
dbwiddis
reviewed
Oct 18, 2024
src/main/java/org/opensearch/flowframework/transport/ReprovisionWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/ReprovisionWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/ReprovisionWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
…ovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com>
dbwiddis
reviewed
Oct 21, 2024
src/main/java/org/opensearch/flowframework/transport/ReprovisionWorkflowTransportAction.java
Outdated
Show resolved
Hide resolved
…ovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com>
…ovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com>
|
Overall LGTM, just a quick question, in the case the reprovisioning itself fails, will have an issue that the template is updated and we need to roll that back? |
amitgalitz
approved these changes
Oct 21, 2024
joshpalis
reviewed
Oct 21, 2024
src/main/java/org/opensearch/flowframework/transport/ReprovisionWorkflowTransportAction.java
Show resolved
Hide resolved
dbwiddis
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Approved pending changelog fix and resolving @joshpalis comment.
joshpalis
approved these changes
Oct 21, 2024
dbwiddis
reviewed
Oct 22, 2024
Signed-off-by: saimedhi <saimedhi@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
…ovisionWorkflowTransportAction (#918) * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com> * Update ReprovisionWorkflowTransportAction.java Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com> * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com> * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction Signed-off-by: saimedhi <saimedhi@amazon.com> * fixed changelog Signed-off-by: saimedhi <saimedhi@amazon.com> --------- Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> (cherry picked from commit 8b387c9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 22, 2024
…tements in ReprovisionWorkflowTransportAction (#925) Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction (#918) * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction * Update ReprovisionWorkflowTransportAction.java * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction * Fixed Template Update Location and Improved Logger Statements in ReprovisionWorkflowTransportAction * fixed changelog --------- (cherry picked from commit 8b387c9) Signed-off-by: saimedhi <saimedhi@amazon.com> Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the template update location in ReprovisionWorkflowTransportAction.java and enhances logger statements for better clarity and debugging.
Related Issues
closes #870
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.