Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replace String concatenation with Log4j ParameterizedMessage for read… #1013

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

owaiskazi19
Copy link
Member

Backport of #943

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ability (opensearch-project#943)

* Replace strings in GetWorkflowTransportAction.java

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>

* Replace strings in 5 files

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>

* Replace strings in 10 files

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>

* Replace strings in 40 files

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>

* Changed back strings, which were not be parametrized

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>

* Update CHANGELOG.md

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>

* Add EOF line break

Signed-off-by: Daniel Widdis <widdis@gmail.com>

---------

Signed-off-by: Patrik Cmil <cmil.patrik@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Co-authored-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Owais <owaiskazi19@gmail.com>
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 42.77457% with 99 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (eb58687) to head (2f73372).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...framework/indices/FlowFrameworkIndicesHandler.java 38.09% 26 Missing ⚠️
...ework/transport/CreateWorkflowTransportAction.java 52.38% 10 Missing ⚠️
...rk/transport/ProvisionWorkflowTransportAction.java 18.18% 9 Missing ⚠️
.../transport/ReprovisionWorkflowTransportAction.java 30.76% 9 Missing ⚠️
...ch/flowframework/workflow/WorkflowStepFactory.java 0.00% 8 Missing ⚠️
...ramework/transport/GetWorkflowTransportAction.java 33.33% 4 Missing ⚠️
.../org/opensearch/flowframework/util/ParseUtils.java 0.00% 4 Missing ⚠️
...search/flowframework/workflow/UpdateIndexStep.java 33.33% 4 Missing ⚠️
...ework/workflow/AbstractRegisterLocalModelStep.java 50.00% 2 Missing and 1 partial ⚠️
...mework/workflow/AbstractRetryableWorkflowStep.java 50.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1013      +/-   ##
============================================
- Coverage     78.08%   77.61%   -0.47%     
  Complexity      993      993              
============================================
  Files            99       99              
  Lines          4617     4714      +97     
  Branches        431      431              
============================================
+ Hits           3605     3659      +54     
- Misses          832      875      +43     
  Partials        180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 7f7141a into opensearch-project:2.x Jan 22, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants