Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for search_idle_reactivate_count_total #8986

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

ruai0511
Copy link
Contributor

Description

Adding documentation for the field "search_idle_reactivate_count_total" in nodes stats api. This field is added in version 2.14 so this PR needs to be backported to 2.14.

The PR for adding in this field in OpenSearch is here.

Version

from version 2.14 to the current version

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ts api

Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ruai0511! One suggestion.

_api-reference/nodes-apis/nodes-stats.md Outdated Show resolved Hide resolved
ruai0511 and others added 2 commits December 30, 2024 12:34
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
@ruai0511
Copy link
Contributor Author

Thank you, @ruai0511! One suggestion.

Thank you for looking into this! I applied the suggestion

@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress backport 2.18 PR: Backport label for 2.18 labels Dec 31, 2024
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws A minor addition 😄

_api-reference/nodes-apis/nodes-stats.md Outdated Show resolved Hide resolved
kolchfa-aws and others added 2 commits January 2, 2025 08:18
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
@kolchfa-aws kolchfa-aws merged commit 20c4baa into opensearch-project:main Jan 2, 2025
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 2, 2025
* Add documentation for search_idle_reactivate_count_total in nodes stats api
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* Update wording for search_idle_reactivate_count_total

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

---------

Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
(cherry picked from commit 20c4baa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress backport 2.18 PR: Backport label for 2.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants