-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made changes to create-index documentation to add copy-as-curl option #6824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
niyatiagg
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable,
stephen-crawford and
epugh
as code owners
April 2, 2024 06:13
Naarcha-AWS
requested changes
Apr 2, 2024
Naarcha-AWS
added
4 - Doc review
PR: Doc review in progress
backport 2.12
PR: Backport label for 2.12
labels
Apr 2, 2024
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Niyati Aggarwal <121826855+niyatiagg@users.noreply.github.com>
kolchfa-aws
reviewed
Apr 3, 2024
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
kolchfa-aws
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Naarcha-AWS
approved these changes
Apr 4, 2024
Naarcha-AWS
added
backport 2.13
PR: Backport label for 2.13
and removed
backport 2.12
PR: Backport label for 2.12
labels
Apr 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
…#6824) * Made changes to create-index doc to add copy-as-curl option Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Update _api-reference/index-apis/delete-index.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Niyati Aggarwal <121826855+niyatiagg@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> Signed-off-by: Niyati Aggarwal <121826855+niyatiagg@users.noreply.github.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit d6f2b32) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Apr 4, 2024
…#6824) (#6878) * Made changes to create-index doc to add copy-as-curl option * Update _api-reference/index-apis/delete-index.md * Apply suggestions from code review --------- (cherry picked from commit d6f2b32) Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> Signed-off-by: Niyati Aggarwal <121826855+niyatiagg@users.noreply.github.com> Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporated 1 click copy-as-curl option for create-index documentation
Issues Resolved
Closes [#6823]
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.