Add include_named_queries_score to docs #6306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dharin Shah <Dharin-shah@users.noreply.github.com>
natebower
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
@kolchfa-aws Just a global comment on the table re: whether the parameter names and "true" and "false" should be in code font. Otherwise, LGTM.
|
@Dharin-shah Is this applicable to 2.12? |
|
@natebower I'll leave it for now because we have lots of instances like this and I'd like to fix all of them together some time. |
no, 3.0.0 and beyond. Also should we wait for the main feature PR to be merged before merging this? i need to make some changes based on some review comments |
|
@Dharin-shah Yes, we will wait until the code is merged to merge this PR. Thanks! |
8 tasks
|
We can merge this as well now :) |
oeyh
pushed a commit
to oeyh/documentation-website
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Dharin Shah <Dharin-shah@users.noreply.github.com> Co-authored-by: Dharin Shah <Dharin-shah@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6278
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.