Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add new documentation for date index name processor #5398

Merged
merged 27 commits into from
Nov 15, 2023
Merged

[DOC] Add new documentation for date index name processor #5398

merged 27 commits into from
Nov 15, 2023

Conversation

vagimeli
Copy link
Contributor

Description

Content gap; add new documentation for date index name processor

Issues Resolved

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli
Add new processor documentation
9a75346 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli self-assigned this Oct 25, 2023
@vagimeli vagimeli added 2 - In progress Issue/PR: The issue or PR is in progress. Content gap labels Oct 25, 2023
@vagimeli
Add new processor documentation
5b086b8 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Add new processor documentation
db4159b 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Copy link
Contributor Author

vagimeli commented Oct 30, 2023 •
edited
Loading

@heemin32 Please review, at your availability, the new date_index_name processor documentation includes the necessary info and technically accurate. Thank you, Melissa

@vagimeli
Merge branch 'main' into date-index-processor
538e1fe 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli added 3 - Tech review PR: Tech review in progress and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Oct 30, 2023
@vagimeli vagimeli mentioned this pull request Nov 3, 2023
Closed
45 tasks
@vagimeli
Copy link
Contributor Author

vagimeli commented Nov 6, 2023

@heemin32 Please review this new processor doc at your availability. Thank you, Melissa

@vagimeli
Address tech review feedback
318e1f7 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Address tech review feedback
353349d 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Merge branch 'main' into date-index-processor
af6429e
@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Nov 8, 2023
@vagimeli
Revise intro and examples to use date math index name use cases
6ad1a3f 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
vagimeli and others added 7 commits November 13, 2023 09:45
@vagimeli
Add date math example
06e7db4 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @heemin32
Update _ingest-pipelines/processors/date-index-name.md
7ac6b41 
Co-authored-by: Heemin Kim <heemin@amazon.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Merge branch 'main' into date-index-processor
cfb9a44
@vagimeli
Add date math example
e044ea5 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Add date math example
b85b7d4 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Update processor example to use date math index expression
83a032c 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Merge branch 'main' into date-index-processor
1e62b04
@vagimeli
Copy link
Contributor Author

@heemin32 @kolchfa-aws I expanded the intro at line 10 to include more info about the date math index expression. I also corrected the response in step 3 and index name in step 4. Please review and approve at your availability. Thank you for your time and examples.

@vagimeli vagimeli added the backport 2.11 PR: Backport label for 2.11 label Nov 13, 2023
@vagimeli
Update processor example to use date math index expression
f5dbdc5 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@kolchfa-aws
Copy link
Collaborator

@vagimeli Could you please fix links?

kolchfa-aws
kolchfa-aws approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments. Please fix links before merging.

_ingest-pipelines/processors/date-index-name.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/date-index-name.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/date-index-name.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/date-index-name.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/date-index-name.md Outdated Show resolved Hide resolved
_ingest-pipelines/processors/date-index-name.md Outdated Show resolved Hide resolved
vagimeli and others added 8 commits November 14, 2023 14:20
@vagimeli @kolchfa-aws
Update _ingest-pipelines/processors/date-index-name.md
150dc27 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @kolchfa-aws
Update _ingest-pipelines/processors/date-index-name.md
d33706a 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @kolchfa-aws
Update _ingest-pipelines/processors/date-index-name.md
68579e0 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @kolchfa-aws
Update _ingest-pipelines/processors/date-index-name.md
4ea66b0 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @kolchfa-aws
Update _ingest-pipelines/processors/date-index-name.md
90111c9 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli @kolchfa-aws
Update _ingest-pipelines/processors/date-index-name.md
e393bdb 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli
Merge branch 'main' into date-index-processor
f8284df
@vagimeli
Fix dead link
bba5595 
Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
@vagimeli vagimeli merged commit 6625a06 into main Nov 15, 2023
@vagimeli vagimeli deleted the date-index-processor branch November 15, 2023 20:13
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 15, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 15, 2023
@github-actions @heemin32 @kolchfa-aws
[DOC] Add new documentation for date index name processor (#5398)
9796b6d 
* Add new processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Heemin Kim <heemin@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit 6625a06)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this pull request Nov 15, 2023
@opensearch-trigger-bot @github-actions
@heemin32 @kolchfa-aws
[DOC] Add new documentation for date index name processor (#5398) (#5607
ebc8d4d 
)

* Add new processor documentation


---------




(cherry picked from commit 6625a06)

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Heemin Kim <heemin@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
vagimeli added a commit that referenced this pull request Dec 21, 2023
@vagimeli @heemin32 @kolchfa-aws
[DOC] Add new documentation for date index name processor (#5398)
bfeabdb 
* Add new processor documentation

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
---------

Signed-off-by: Melissa Vagi <vagimeli@amazon.com>
Co-authored-by: Heemin Kim <heemin@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heemin32 heemin32 heemin32 approved these changes

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@ananzh ananzh Awaiting requested review from ananzh

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

Assignees

@vagimeli vagimeli

Labels
4 - Doc review PR: Doc review in progress backport 2.11 PR: Backport label for 2.11 Content gap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vagimeli @kolchfa-aws @heemin32