Add concurrent segment search documentation #4990
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -221,12 +221,12 @@ Field | Data type | Description | |
| `profile.shards` | Array of objects | A search request can be executed against one or more shards in the index, and a search may involve one or more indexes. Thus, the `profile.shards` array contains profiling information for each shard that was involved in the search. | ||
| `profile.shards.id` | String | The shard ID of the shard in the `[node-ID][index-name][shard-ID]` format. | ||
| `profile.shards.searches` | Array of objects | A search represents a query executed against the underlying Lucene index. Most search requests execute a single search against a Lucene index, but some search requests can execute more than one search. For example, including a global aggregation results in a secondary `match_all` query for the global context. The `profile.shards` array contains profiling information about each search execution. | ||
| [`profile.shards.searches.query`](#the-query-array) | Array of objects | Profiling information about the query execution. | ||
| `profile.shards.searches.rewrite_time` | Integer | All Lucene queries are rewritten. A query and its children may be rewritten more than once, until the query stops changing. The rewriting process involves performing optimizations, such as removing redundant clauses or replacing a query path with a more efficient one. After the rewriting process, the original query may change significantly. The `rewrite_time` field contains the cumulative total rewrite time for the query and all its children, in nanoseconds. | ||
| [`profile.shards.searches.collector`](#the-collector-array) | Array of objects | Profiling information about the Lucene collectors that ran the search. | ||
| [`profile.shards.aggregations`](#aggregations) | Array of objects | Profiling information about the aggregation execution. | ||
|
|
||
| ### The `query` array | ||
|
|
||
| The `query` object contains the following fields. | ||
|
There was a problem hiding this comment. Should "object" be changed to "array?" |
||
|
|
||
|
|
@@ -753,4 +753,215 @@ Field | Description | |
| `post_collection`| Contains the time spent running the aggregation’s `postCollection()` callback method. | ||
| `build_aggregation`| Contains the time spent running the aggregation’s `buildAggregations()` method, which builds the results of this aggregation. | ||
| `reduce`| Contains the time spent in the `reduce` phase. | ||
| `<method>_count` | Contains the number of invocations of a `<method>`. For example, `build_leaf_collector_count` contains the number of invocations of the `build_leaf_collector` method. | ||
|
|
||
| ## Concurrent segment search | ||
|
|
||
| Starting with OpenSearch 2.10, you can perform [concurrent segment search]({{site.url}}{{site.baseurl}}/search-plugins/concurrent-segment-search/), in which each shard-level request will search the segments in parallel during query phase. If you enable the experimental concurrent segment search feature flag, the Profile API response will contain several additional fields with statistics about _slices_. | ||
|
|
||
|
|
||
| A slice is the unit of work that can be executed by a thread. Each query can be partitioned into multiple slices, with each slice containing one or more segments. All the slices can be executed either in parallel or in some order depending on the available threads in the pool. | ||
|
|
||
| In general, the max/min/avg slice time captures statistics across all slices for a timing type. For example, when profiling aggregations, the `max_slice_time_in_nanos` field in the `aggregations` section shows the maximum time consumed by the aggregation operation and its children across all slices. | ||
|
|
||
| #### Example response | ||
|
|
||
| The following is an example response for a concurrent search with three segment slices: | ||
|
There was a problem hiding this comment. Should we mention this response has profile enabled? There was a problem hiding this comment. This file is the Profile API documentation and it states in the very beginning that you have to set There was a problem hiding this comment. @ticheng-aws are any of these response fields gated by the concurrent search feature flag? If so I think we should call those out. There was a problem hiding this comment. The new fields are not gated by the concurrent search feature flag. |
||
|
|
||
| <details closed markdown="block"> | ||
| <summary> | ||
| Response | ||
| </summary> | ||
| {: .text-delta} | ||
|
|
||
| ```json | ||
| { | ||
| "took": 76, | ||
| "timed_out": false, | ||
| "_shards": { | ||
| "total": 1, | ||
| "successful": 1, | ||
| "skipped": 0, | ||
| "failed": 0 | ||
| }, | ||
| "hits": { | ||
| "total": { | ||
| "value": 5, | ||
| "relation": "eq" | ||
| }, | ||
| "max_score": 1, | ||
| "hits": [ | ||
|
There was a problem hiding this comment.
|
||
| ... | ||
| ] | ||
| }, | ||
| "aggregations": { | ||
| ... | ||
| }, | ||
| "profile": { | ||
| "shards": [ | ||
| { | ||
| "id": "[Sn2zHhcMTRetEjXvppU8bA][idx][0]", | ||
| "inbound_network_time_in_millis": 0, | ||
| "outbound_network_time_in_millis": 0, | ||
| "searches": [ | ||
| { | ||
| "query": [ | ||
| { | ||
| "type": "MatchAllDocsQuery", | ||
| "description": "*:*", | ||
| "time_in_nanos": 429246, | ||
| "breakdown": { | ||
| "set_min_competitive_score_count": 0, | ||
| "match_count": 0, | ||
| "shallow_advance_count": 0, | ||
| "set_min_competitive_score": 0, | ||
| "next_doc": 5485, | ||
| "match": 0, | ||
| "next_doc_count": 5, | ||
| "score_count": 5, | ||
| "compute_max_score_count": 0, | ||
| "compute_max_score": 0, | ||
| "advance": 3350, | ||
| "advance_count": 3, | ||
| "score": 5920, | ||
| "build_scorer_count": 6, | ||
| "create_weight": 429246, | ||
| "shallow_advance": 0, | ||
| "create_weight_count": 1, | ||
| "build_scorer": 2221054 | ||
| } | ||
| } | ||
| ], | ||
| "rewrite_time": 12442, | ||
| "collector": [ | ||
| { | ||
| "name": "QueryCollectorManager", | ||
| "reason": "search_multi", | ||
| "time_in_nanos": 6786930, | ||
| "reduce_time_in_nanos": 5892759, | ||
| "max_slice_time_in_nanos": 5951808, | ||
| "min_slice_time_in_nanos": 5798174, | ||
| "avg_slice_time_in_nanos": 5876588, | ||
| "slice_count": 3, | ||
| "children": [ | ||
| { | ||
| "name": "SimpleTopDocsCollectorManager", | ||
| "reason": "search_top_hits", | ||
| "time_in_nanos": 1340186, | ||
| "reduce_time_in_nanos": 1084060, | ||
| "max_slice_time_in_nanos": 457165, | ||
| "min_slice_time_in_nanos": 433706, | ||
| "avg_slice_time_in_nanos": 443332, | ||
| "slice_count": 3 | ||
| }, | ||
| { | ||
| "name": "NonGlobalAggCollectorManager: [histo]", | ||
| "reason": "aggregation", | ||
| "time_in_nanos": 5366791, | ||
| "reduce_time_in_nanos": 4637260, | ||
| "max_slice_time_in_nanos": 4526680, | ||
| "min_slice_time_in_nanos": 4414049, | ||
| "avg_slice_time_in_nanos": 4487122, | ||
| "slice_count": 3 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "aggregations": [ | ||
| { | ||
| "type": "NumericHistogramAggregator", | ||
| "description": "histo", | ||
| "time_in_nanos": 16454372, | ||
| "max_slice_time_in_nanos": 7342096, | ||
| "min_slice_time_in_nanos": 4413728, | ||
| "avg_slice_time_in_nanos": 5430066, | ||
| "breakdown": { | ||
| "min_build_leaf_collector": 4320259, | ||
| "build_aggregation_count": 3, | ||
| "post_collection": 9942, | ||
| "max_collect_count": 2, | ||
| "initialize_count": 3, | ||
| "reduce_count": 0, | ||
| "avg_collect": 146319, | ||
| "max_build_aggregation": 2826399, | ||
| "avg_collect_count": 1, | ||
| "max_build_leaf_collector": 4322299, | ||
| "min_build_leaf_collector_count": 1, | ||
| "build_aggregation": 3038635, | ||
| "min_initialize": 1057, | ||
| "max_reduce": 0, | ||
| "build_leaf_collector_count": 3, | ||
| "avg_reduce": 0, | ||
| "min_collect_count": 1, | ||
| "avg_build_leaf_collector_count": 1, | ||
| "avg_build_leaf_collector": 4321197, | ||
| "max_collect": 181266, | ||
| "reduce": 0, | ||
| "avg_build_aggregation": 954896, | ||
| "min_post_collection": 1236, | ||
| "max_initialize": 11603, | ||
| "max_post_collection": 5350, | ||
| "collect_count": 5, | ||
| "avg_post_collection": 2793, | ||
| "avg_initialize": 4860, | ||
| "post_collection_count": 3, | ||
| "build_leaf_collector": 4322299, | ||
| "min_collect": 78519, | ||
| "min_build_aggregation": 8543, | ||
| "initialize": 11971068, | ||
| "max_build_leaf_collector_count": 1, | ||
| "min_reduce": 0, | ||
| "collect": 181838 | ||
| }, | ||
| "debug": { | ||
| "total_buckets": 1 | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ``` | ||
| </details> | ||
|
|
||
| ### Modified or added response fields | ||
|
|
||
| The following sections contain definitions of all modified or added response fields for concurrent segment search. | ||
|
|
||
| #### The `query` array | ||
|
|
||
| |Field |Description | | ||
| |:--- |:--- | | ||
| |`time_in_nanos` |For concurrent segment search, `time_in_nanos` is the cumulative amount of time to execute all methods across all slices, in nanoseconds. This is not equivalent to the actual amount of time the query took to execute because it does not take into account that multiple slices can execute the methods in parallel. | | ||
kolchfa-aws marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| |`breakdown.<method>` |For concurrent segment search, this field contains the total amount of time taken by all segments to execute a method. | | ||
kolchfa-aws marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| |`breakdown.<method>_count` |For concurrent segment search, this field contains the total number of invocations of a `<method>` obtained by adding the number of method invocations for all segments. | | ||
|
|
||
| #### The `collector` array | ||
|
|
||
| |Field |Description | | ||
| |:--- |:--- | | ||
| |`time_in_nanos` |The total elapsed time for this collector, in nanoseconds. For concurrent segment search, `time_in_nanos` is the total amount of time across all slices (`max(slice_end_time) - min(slice_start_time)`). | | ||
| |`max_slice_time_in_nanos` |The maximum amount of time taken by any slice, in nanoseconds. | | ||
| |`min_slice_time_in_nanos` |The minimum amount of time taken by any slice, in nanoseconds. | | ||
| |`avg_slice_time_in_nanos` |The average amount of time taken by any slice, in nanoseconds. | | ||
| |`slice_count` |The total slice count for this query. | | ||
| |`reduce_time_in_nanos` |The amount of time it took to reduce results for all slice collectors, in nanoseconds. | | ||
kolchfa-aws marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| #### The `aggregations` array | ||
|
|
||
| |Field |Description | | ||
| |:--- |:--- | | ||
| |`time_in_nanos` |The total elapsed time for this aggregation, in nanoseconds. For concurrent segment search, `time_in_nanos` is the total amount of time across all slices (`max(slice_end_time) - min(slice_start_time)`). | | ||
| |`max_slice_time_in_nanos` |The maximum amount of time taken by any slice to run an aggregation, in nanoseconds. | | ||
| |`min_slice_time_in_nanos` |The minimum amount of time taken by any slice to run an aggregation, in nanoseconds. | | ||
| |`avg_slice_time_in_nanos` |The average amount of time taken by any slice to run an aggregation, in nanoseconds. | | ||
| |`<method>` |The total elapsed time across all slices (`max(slice_end_time) - min(slice_start_time)`). For example, for the `collect` method, it is the total time spent collecting documents into buckets across all slices. | | ||
| |`max_<method>` |The maximum amount of time taken by any slice to run an aggregation method. | | ||
| |`min_<method>`|The minimum amount of time taken by any slice to run an aggregation method. | | ||
| |`avg_<method>` |The average amount of time taken by any slice to run an aggregation method. | | ||
| |`<method>_count` |The total method count across all slices. For example, for the `collect` method, it is the total number of invocations of this method in order to collect documents into buckets across all slices. | | ||
|
There was a problem hiding this comment. Should "in order" be "needed"? |
||
| |`max_<method>_count` |The maximum number of invocations of a `<method>` on any slice. | | ||
| |`min_<method>_count` |The minimum number of invocations of a `<method>` on any slice. | | ||
| |`avg_<method>_count` |The average number of invocations of a `<method>` on any slice. | | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These stats will also show up in nodes-stats as well as
_cat/nodes,_cat/shards,_cat/indicesbut for the_catAPIs users can find it in the help section of the API.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws since all of these stats are gated by the concurrent search feature flag, I was thinking this information should be kept all within the
concurrent-segment-search.mdpage too? I don't think we need to add these to the API pages until the feature is GA and the feature flag is removed, but it would be good to have the table below somewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the two options are:
It's a matter of opinion, but I think it makes it easier if the API changes are kept in the API pages. Users won't see concurrent-segment-related fields if they don't enable the feature, so I don't think there's any harm in keeping them in the API pages, especially because they are in a separate table. The danger with keeping them in the main page is that someone can just remove the experimental header and not add the API changes in the GA release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can track this is an issue somewhere - perhaps #3662
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment so we can track