New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Restructure Dashboards TOC #2628

Merged

vagimeli merged 16 commits into main from 2621-TOC

Feb 6, 2023

Contributor

vagimeli commented Feb 3, 2023

Signed-off-by: vagimeli vagimeli@amazon.com

Description

Restructures Dashboards TOC

Issues Resolved

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.


          Organize TOC in logical order and delete viz type page

2f2dfec

Signed-off-by: vagimeli <vagimeli@amazon.com>

vagimeli requested a review from a team as a code owner

February 3, 2023 18:37

vagimeli self-assigned this

vagimeli added backport 1.3 backport 2.0 backport 2.1 backport 2.2 backport 2.3 backport 2.4 backport 2.5 labels

vagimeli added 7 commits

February 3, 2023 11:39


          Copy edit to delete redundant bullets in quickstart intro

fa0bd72

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Format nav order

5f70fea

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Copy edits

7bfb893

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Format nav order

3c7be79

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Format nav order

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Copy edit title to use gerund

83bf504

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Format nav order

ab43dfc

Signed-off-by: vagimeli <vagimeli@amazon.com>

Contributor Author

vagimeli commented Feb 3, 2023

Proposed TOC structure

hdhalter reviewed

View reviewed changes

Contributor

hdhalter left a comment

Looks good, Melissa! I lean toward dropping any UI terms used in our headings. I assume we want to tie ideas to the UI but I think we can handle that in the procedures.

_dashboards/quickstart-dashboards.md Outdated Show resolved Hide resolved

_dashboards/quickstart-dashboards.md Outdated Show resolved Hide resolved

_dashboards/visualize/viz-index.md Outdated

@@ @@ -1,7 +1,7 @@ @@
               ---
               layout: default
-              title: Visualize
-              nav_order: 4
+              title: Building data visualizations with Visualize

Contributor

hdhalter Feb 3, 2023

Can we drop 'with Visualize'?

Contributor Author

vagimeli Feb 3, 2023

Visualize is the application on the UI.

Contributor Author

vagimeli Feb 3, 2023

Contributor Author

vagimeli Feb 3, 2023

@hdhalter Changes made as suggested.

Contributor Author

vagimeli Feb 3, 2023

TOC updates

vagimeli added 4 commits

February 3, 2023 14:49


          Address doc review feedback

743fa1c

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Update links

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Copy edit

5be26f3

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Update title

ea71a8b

Signed-off-by: vagimeli <vagimeli@amazon.com>

Contributor Author

vagimeli commented Feb 4, 2023 •

edited

Loading

Thanks! I agree with you about UI. Good point.

alicejw1 approved these changes

View reviewed changes

Contributor

alicejw1 left a comment

Great work!

made a couple of minor comments

_dashboards/visualize/geojson-regionmaps.md Outdated Show resolved Hide resolved

_dashboards/visualize/geojson-regionmaps.md Outdated Show resolved Hide resolved

_dashboards/reporting.md Outdated Show resolved Hide resolved

_dashboards/visualize/maptiles.md Outdated Show resolved Hide resolved

vagimeli and others added 2 commits

February 6, 2023 11:50


          Update _dashboards/visualize/geojson-regionmaps.md

55e24fd

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>


          Update _dashboards/visualize/geojson-regionmaps.md

1f8fe8b

Co-authored-by: Alice Williams <88908598+alicejw-aws@users.noreply.github.com>

cwillum approved these changes

View reviewed changes

Contributor

cwillum left a comment

LGTM

vagimeli added 2 commits

February 6, 2023 12:41


          Copy edits

bfbb30d

Signed-off-by: vagimeli <vagimeli@amazon.com>


          Copy edits

2dbb404

Signed-off-by: vagimeli <vagimeli@amazon.com>

vagimeli merged commit 6511176 into main

vagimeli changed the title ~~[DOC] Restructures Dashboards TOC~~ [DOC] Restructure Dashboards TOC

Contributor

opensearch-trigger-bot bot commented Feb 6, 2023

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2628-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65111760b7b9063abed5b12480722989b26eef21
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-2628-to-1.3.

Contributor

opensearch-trigger-bot bot commented Feb 6, 2023

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-2628-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65111760b7b9063abed5b12480722989b26eef21
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-2628-to-2.0.

Contributor

opensearch-trigger-bot bot commented Feb 6, 2023

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-2628-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65111760b7b9063abed5b12480722989b26eef21
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-2628-to-2.1.

Contributor

opensearch-trigger-bot bot commented Feb 6, 2023

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-2628-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65111760b7b9063abed5b12480722989b26eef21
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-2628-to-2.2.

Contributor

opensearch-trigger-bot bot commented Feb 6, 2023

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2628-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65111760b7b9063abed5b12480722989b26eef21
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-2628-to-2.3.

Contributor

opensearch-trigger-bot bot commented Feb 6, 2023

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-2628-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 65111760b7b9063abed5b12480722989b26eef21
# Push it to GitHub
git push --set-upstream origin backport/backport-2628-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-2628-to-2.4.

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          [DOC] Restructures Dashboards TOC (#2628)

9cf7f00

* Organize Dashboards TOC in logical order; copy edits for spelling and style guide compliance

Signed-off-by: vagimeli <vagimeli@amazon.com>
(cherry picked from commit 6511176)

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.5] Restructure Dashboards TOC #2669

Merged

vagimeli added a commit that referenced this pull request


          [DOC] Restructures Dashboards TOC (#2628) (#2669)

a4df4e8

* Organize Dashboards TOC in logical order; copy edits for spelling and style guide compliance

Signed-off-by: vagimeli <vagimeli@amazon.com>
(cherry picked from commit 6511176)

Co-authored-by: Melissa Vagi <105296784+vagimeli@users.noreply.github.com>

vagimeli deleted the 2621-TOC branch

February 9, 2023 18:35

vagimeli added the Closed - Complete label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.3 backport 2.0 backport 2.1 backport 2.2 backport 2.3 backport 2.4 backport 2.5 Closed - Complete