[CI/CD] Add eslint workflow #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
ps48
previously approved these changes
Jan 11, 2024
joshuali925
reviewed
Jan 11, 2024
|
@RyanL1997 Also, styleLint step in test and build workflows are failing: |
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 5 5
Lines 152 152
Branches 45 45
=======================================
Hits 144 144
Misses 8 8 ☔ View full report in Codecov by Sentry. |
@ps48 . Good Catch. I have added the |
mengweieric
approved these changes
Jan 12, 2024
Swiddis
approved these changes
Jan 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* Add eslint workflow Signed-off-by: Ryan Liang <jiallian@amazon.com> * Correct the plugin name Signed-off-by: Ryan Liang <jiallian@amazon.com> * Correct the plugin name2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * change the linting running dir Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix some comments Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add stylelint back Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 09ef7f9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
added a commit
to RyanL1997/dashboards-visualizations
that referenced
this pull request
Jan 19, 2024
* Add eslint workflow Signed-off-by: Ryan Liang <jiallian@amazon.com> * Correct the plugin name Signed-off-by: Ryan Liang <jiallian@amazon.com> * Correct the plugin name2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * change the linting running dir Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix some comments Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add stylelint back Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add eslint workflow
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.