Resolve tough-cookie to 4.1.3 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on recommendation by @AMoo-Miki on opensearch-project/opensearch-build#3856 Signed-off-by: Michael Froh <froh@amazon.com>
mingshl
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 15 15
Lines 204 204
Branches 40 40
=======================================
Hits 176 176
Misses 26 26
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I would consider it as a temporary solution; for the long run, we will remove cypress dependency #266. |
github-actions bot
added a commit
that referenced
this pull request
Sep 5, 2023
(cherry picked from commit 6c0d17c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh
pushed a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on recommendation by @AMoo-Miki on
opensearch-project/opensearch-build#3856
Description
Regenerating our yarn.lock file, as done by the automation to bump version numbers with each release, downgrades our tough-cookie dependency from 4.1.3 to 2.5, because the version of Cypress that we use depends on 2.5.
To avoid the downgrade, we should update our package.json to reflect the version that we intend to use.
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.