-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added supoort for metrics MDS #1876
Conversation
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
==========================================
- Coverage 57.85% 55.64% -2.21%
==========================================
Files 372 386 +14
Lines 14081 14789 +708
Branches 3712 3926 +214
==========================================
+ Hits 8146 8229 +83
- Misses 5871 6485 +614
- Partials 64 75 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Screen.Recording.2024-06-07.at.10.26.14.AM.mov |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
); | ||
|
||
const dataSourceMDSId = request.params.dataSourceMDSId; | ||
let opensearchNotebooksClient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Not sure if this should be named notebooks client
@@ -19,11 +19,15 @@ export default class PPLService { | |||
query: string; | |||
format: string; | |||
}, | |||
dataSourceMDSId?: string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change do we need to add MDS param here: https://github.com/opensearch-project/dashboards-observability/blob/19d68b2d443458c3fdb1bd0fe035bf823111015b/public/services/timestamp/timestamp.ts#L81C9-L81C28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @sumukhswamy offline this isn't being used by metrics analytics.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1876-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b37040461710c75924ac7f300f11591bdd538a88
# Push it to GitHub
git push --set-upstream origin backport/backport-1876-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
Description
With multiple data source enabled, users of OpenSearch Dashboards with Metrics analytics are able to fetch metrics from local and remote clusters
MDS support for metrics analytics
#1754
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.