Updating app analytics jest and cypress tests #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
… and explorer times Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
…d parsing Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
joshuali925
approved these changes
Feb 2, 2024
mengweieric
approved these changes
Feb 2, 2024
|
Also wanted to add is please separate your changes into multiple PRs moving forward, in this case maybe unit tests and integration tests. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* some updates Signed-off-by: Paul Sebastian <paulstn@amazon.com> * beginning assertion Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix typo Signed-off-by: Paul Sebastian <paulstn@amazon.com> * TEMPORARY: only run app analytics github action Signed-off-by: Paul Sebastian <paulstn@amazon.com> * included wait for all requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * explicitly add sample data flights and logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * otel imported Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update otel requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reintroduce otel data Signed-off-by: Paul Sebastian <paulstn@amazon.com> * switch browser to electron Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed issues with timepicker not being shared properly, separated app and explorer times Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small updates to spec Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix some of the time logic Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small fixes to spec Signed-off-by: Paul Sebastian <paulstn@amazon.com> * double click to open service flyout, doesn't work otherwise Signed-off-by: Paul Sebastian <paulstn@amazon.com> * click to render chart Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed issue where availability lines weren't showing up due to deleted parsing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * extra character for query while autocomplete issue is being worked on Signed-off-by: Paul Sebastian <paulstn@amazon.com> * uncomment everything whoops Signed-off-by: Paul Sebastian <paulstn@amazon.com> * typing bandaid Signed-off-by: Paul Sebastian <paulstn@amazon.com> * intercept loading panel and remove waits Signed-off-by: Paul Sebastian <paulstn@amazon.com> * minimally viable testing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * switch back to electron Signed-off-by: Paul Sebastian <paulstn@amazon.com> * temp load data for ftr run Signed-off-by: Paul Sebastian <paulstn@amazon.com> * change waiting order Signed-off-by: Paul Sebastian <paulstn@amazon.com> * only need one loading panels wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update ftr tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include two network intercepts Signed-off-by: Paul Sebastian <paulstn@amazon.com> * ftr test update delete success getter Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add intercept after selection Signed-off-by: Paul Sebastian <paulstn@amazon.com> * take into account new name Signed-off-by: Paul Sebastian <paulstn@amazon.com> * manual wait to isolate other issues Signed-off-by: Paul Sebastian <paulstn@amazon.com> * repeat test 10 times to check for flakiness Signed-off-by: Paul Sebastian <paulstn@amazon.com> * revert repeat 10 tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove ftr test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * go back to running all integration tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce usage of within Signed-off-by: Paul Sebastian <paulstn@amazon.com> * run app analytics test 10 times on github runner Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add wait to avoid test avoiding checkbox Signed-off-by: Paul Sebastian <paulstn@amazon.com> * explain why i have a wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove repeating tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * change and remove some jest tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 3733eeb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* some updates Signed-off-by: Paul Sebastian <paulstn@amazon.com> * beginning assertion Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix typo Signed-off-by: Paul Sebastian <paulstn@amazon.com> * TEMPORARY: only run app analytics github action Signed-off-by: Paul Sebastian <paulstn@amazon.com> * included wait for all requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * explicitly add sample data flights and logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * otel imported Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update otel requests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reintroduce otel data Signed-off-by: Paul Sebastian <paulstn@amazon.com> * switch browser to electron Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed issues with timepicker not being shared properly, separated app and explorer times Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small updates to spec Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix some of the time logic Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small fixes to spec Signed-off-by: Paul Sebastian <paulstn@amazon.com> * double click to open service flyout, doesn't work otherwise Signed-off-by: Paul Sebastian <paulstn@amazon.com> * click to render chart Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed issue where availability lines weren't showing up due to deleted parsing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * extra character for query while autocomplete issue is being worked on Signed-off-by: Paul Sebastian <paulstn@amazon.com> * uncomment everything whoops Signed-off-by: Paul Sebastian <paulstn@amazon.com> * typing bandaid Signed-off-by: Paul Sebastian <paulstn@amazon.com> * intercept loading panel and remove waits Signed-off-by: Paul Sebastian <paulstn@amazon.com> * minimally viable testing Signed-off-by: Paul Sebastian <paulstn@amazon.com> * switch back to electron Signed-off-by: Paul Sebastian <paulstn@amazon.com> * temp load data for ftr run Signed-off-by: Paul Sebastian <paulstn@amazon.com> * change waiting order Signed-off-by: Paul Sebastian <paulstn@amazon.com> * only need one loading panels wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update ftr tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include two network intercepts Signed-off-by: Paul Sebastian <paulstn@amazon.com> * ftr test update delete success getter Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add intercept after selection Signed-off-by: Paul Sebastian <paulstn@amazon.com> * take into account new name Signed-off-by: Paul Sebastian <paulstn@amazon.com> * manual wait to isolate other issues Signed-off-by: Paul Sebastian <paulstn@amazon.com> * repeat test 10 times to check for flakiness Signed-off-by: Paul Sebastian <paulstn@amazon.com> * revert repeat 10 tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove ftr test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * go back to running all integration tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * reduce usage of within Signed-off-by: Paul Sebastian <paulstn@amazon.com> * run app analytics test 10 times on github runner Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add wait to avoid test avoiding checkbox Signed-off-by: Paul Sebastian <paulstn@amazon.com> * explain why i have a wait Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove repeating tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * change and remove some jest tests Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 3733eeb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Feb 6, 2024
* some updates * beginning assertion * fix typo * TEMPORARY: only run app analytics github action * included wait for all requests * explicitly add sample data flights and logs * otel imported * update otel requests * reintroduce otel data * switch browser to electron * fixed issues with timepicker not being shared properly, separated app and explorer times * small updates to spec * fix some of the time logic * small fixes to spec * double click to open service flyout, doesn't work otherwise * click to render chart * fixed issue where availability lines weren't showing up due to deleted parsing * extra character for query while autocomplete issue is being worked on * uncomment everything whoops * typing bandaid * intercept loading panel and remove waits * minimally viable testing * switch back to electron * temp load data for ftr run * change waiting order * only need one loading panels wait * update ftr tests * include two network intercepts * ftr test update delete success getter * add intercept after selection * take into account new name * manual wait to isolate other issues * repeat test 10 times to check for flakiness * revert repeat 10 tests * updated snapshots * remove ftr test * go back to running all integration tests * reduce usage of within * run app analytics test 10 times on github runner * add wait to avoid test avoiding checkbox * explain why i have a wait * remove repeating tests * small changes * change and remove some jest tests --------- (cherry picked from commit 3733eeb) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Feb 6, 2024
* some updates * beginning assertion * fix typo * TEMPORARY: only run app analytics github action * included wait for all requests * explicitly add sample data flights and logs * otel imported * update otel requests * reintroduce otel data * switch browser to electron * fixed issues with timepicker not being shared properly, separated app and explorer times * small updates to spec * fix some of the time logic * small fixes to spec * double click to open service flyout, doesn't work otherwise * click to render chart * fixed issue where availability lines weren't showing up due to deleted parsing * extra character for query while autocomplete issue is being worked on * uncomment everything whoops * typing bandaid * intercept loading panel and remove waits * minimally viable testing * switch back to electron * temp load data for ftr run * change waiting order * only need one loading panels wait * update ftr tests * include two network intercepts * ftr test update delete success getter * add intercept after selection * take into account new name * manual wait to isolate other issues * repeat test 10 times to check for flakiness * revert repeat 10 tests * updated snapshots * remove ftr test * go back to running all integration tests * reduce usage of within * run app analytics test 10 times on github runner * add wait to avoid test avoiding checkbox * explain why i have a wait * remove repeating tests * small changes * change and remove some jest tests --------- (cherry picked from commit 3733eeb) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
…arch-project#1398) Signed-off-by: Ryan Liang <jiallian@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
… (opensearch-project#1416) * some updates * beginning assertion * fix typo * TEMPORARY: only run app analytics github action * included wait for all requests * explicitly add sample data flights and logs * otel imported * update otel requests * reintroduce otel data * switch browser to electron * fixed issues with timepicker not being shared properly, separated app and explorer times * small updates to spec * fix some of the time logic * small fixes to spec * double click to open service flyout, doesn't work otherwise * click to render chart * fixed issue where availability lines weren't showing up due to deleted parsing * extra character for query while autocomplete issue is being worked on * uncomment everything whoops * typing bandaid * intercept loading panel and remove waits * minimally viable testing * switch back to electron * temp load data for ftr run * change waiting order * only need one loading panels wait * update ftr tests * include two network intercepts * ftr test update delete success getter * add intercept after selection * take into account new name * manual wait to isolate other issues * repeat test 10 times to check for flakiness * revert repeat 10 tests * updated snapshots * remove ftr test * go back to running all integration tests * reduce usage of within * run app analytics test 10 times on github runner * add wait to avoid test avoiding checkbox * explain why i have a wait * remove repeating tests * small changes * change and remove some jest tests --------- (cherry picked from commit 3733eeb) Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 489bb8c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actual file diff: https://github.com/paulstn/dashboards-observability/compare/main..app-analytics-test-coverage
Description
[Describe what this change achieves]
Issues Resolved
#21
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.