Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Notebook jest updates (#1307) #1346

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jan 9, 2024

  • fix support for observability visualizations

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • update note_table tests

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • notebook.tsx test first update

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • update paragraph/notebook action tests

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • lint fixes

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • updating paragraph components

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • add test for rendering error in query

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • snapshot updates and adding missing tests

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • remove unnecessary jest mock import

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • history.push jest function added

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • merge notebooks tests contants file

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • make tests more atomic

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • updated snapshot

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

  • atomicized code block checks

Signed-off-by: Shenoy Pratik sgguruda@amazon.com


Signed-off-by: Shenoy Pratik sgguruda@amazon.com
(cherry picked from commit de90b01)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* fix support for observability visualizations

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update note_table tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* notebook.tsx test first update

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update paragraph/notebook action tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* lint fixes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updating paragraph components

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add test for rendering error in query

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* snapshot updates and adding missing tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove unnecessary jest mock import

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* history.push jest function added

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* merge notebooks tests contants file

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* make tests more atomic

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated snapshot

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* atomicized code block checks

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit de90b01)
@ps48 ps48 marked this pull request as ready for review January 9, 2024 18:22
@ps48 ps48 changed the title Notebook jest updates (#1307) [Backport 2.x] Notebook jest updates (#1307) Jan 9, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (145efe5) 51.34% compared to head (418fb5a) 52.90%.

Files Patch % Lines
...ublic/components/notebooks/components/notebook.tsx 36.84% 12 Missing ⚠️
...omponents/paragraph_components/para_query_grid.tsx 43.75% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1346      +/-   ##
==========================================
+ Coverage   51.34%   52.90%   +1.56%     
==========================================
  Files         303      302       -1     
  Lines       10592    10594       +2     
  Branches     2778     2777       -1     
==========================================
+ Hits         5438     5605     +167     
+ Misses       5108     4944     -164     
+ Partials       46       45       -1     
Flag Coverage Δ
dashboards-observability 52.90% <64.40%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 5454b17 into opensearch-project:2.x Jan 9, 2024
@ps48 ps48 deleted the backport/backport-1307-to-2.x-1 branch January 9, 2024 19:25
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…earch-project#1346)

* Notebook jest updates  (opensearch-project#1307)

* fix support for observability visualizations

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update note_table tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* notebook.tsx test first update

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update paragraph/notebook action tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* lint fixes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updating paragraph components

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add test for rendering error in query

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* snapshot updates and adding missing tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove unnecessary jest mock import

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* history.push jest function added

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* merge notebooks tests contants file

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* make tests more atomic

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* updated snapshot

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* atomicized code block checks

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit de90b01)

* update para_query_grid

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 5454b17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants