-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Notebook jest updates (#1307) #1346
Merged
ps48
merged 2 commits into
opensearch-project:2.x
from
ps48:backport/backport-1307-to-2.x-1
Jan 9, 2024
Merged
[Backport 2.x] Notebook jest updates (#1307) #1346
ps48
merged 2 commits into
opensearch-project:2.x
from
ps48:backport/backport-1307-to-2.x-1
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix support for observability visualizations Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update note_table tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * notebook.tsx test first update Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update paragraph/notebook action tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * lint fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updating paragraph components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add test for rendering error in query Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * snapshot updates and adding missing tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unnecessary jest mock import Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * history.push jest function added Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * merge notebooks tests contants file Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * make tests more atomic Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * atomicized code block checks Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit de90b01)
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1346 +/- ##
==========================================
+ Coverage 51.34% 52.90% +1.56%
==========================================
Files 303 302 -1
Lines 10592 10594 +2
Branches 2778 2777 -1
==========================================
+ Hits 5438 5605 +167
+ Misses 5108 4944 -164
+ Partials 46 45 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Jan 9, 2024
kavithacm
approved these changes
Jan 9, 2024
seankao-az
approved these changes
Jan 9, 2024
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…earch-project#1346) * Notebook jest updates (opensearch-project#1307) * fix support for observability visualizations Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update note_table tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * notebook.tsx test first update Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update paragraph/notebook action tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * lint fixes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updating paragraph components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add test for rendering error in query Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * snapshot updates and adding missing tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unnecessary jest mock import Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * history.push jest function added Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * merge notebooks tests contants file Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * make tests more atomic Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * updated snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * atomicized code block checks Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit de90b01) * update para_query_grid Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 5454b17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
Signed-off-by: Shenoy Pratik sgguruda@amazon.com
(cherry picked from commit de90b01)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.