[BACKPORT]Fix no matching issue corner case for lint CI (#1317) #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* no matching corner case Signed-off-by: Eric <menwe@amazon.com> * adjust some linting rules Signed-off-by: Eric <menwe@amazon.com> * using bash array Signed-off-by: Eric <menwe@amazon.com> * improve linter Signed-off-by: Eric <menwe@amazon.com> * remove redundant check Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
ps48
approved these changes
Dec 22, 2023
RyanL1997
approved these changes
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1326 +/- ##
==========================================
- Coverage 51.61% 51.60% -0.01%
==========================================
Files 305 305
Lines 10652 10652
Branches 2789 2789
==========================================
- Hits 5498 5497 -1
- Misses 5108 5109 +1
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swiddis
approved these changes
Dec 28, 2023
6 tasks
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
… (opensearch-project#1326) * no matching corner case * adjust some linting rules * using bash array * improve linter * remove redundant check --------- Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 9c15db0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no matching corner case
adjust some linting rules
using bash array
improve linter
remove redundant check
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.