Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Explorer updated with PromQL #1303

Conversation

pjfitzgibbons
Copy link
Contributor

including query for Prometheus Metrics and updated Export Panel

Signed-off-by: Peter Fitzgibbons peter.fitzgibbons@gmail.com

Description

Manual backport from #1291

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

including query for Prometheus Metrics and updated Export Panel

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 221 lines in your changes are missing coverage. Please review.

Comparison is base (11ecfa6) 56.42% compared to head (59ad6de) 57.49%.

Files Patch % Lines
...lic/components/metrics/top_menu/metrics_export.tsx 55.62% 67 Missing ⚠️
public/components/custom_panels/helpers/utils.tsx 25.53% 35 Missing ⚠️
...blic/components/custom_panels/redux/panel_slice.ts 18.91% 30 Missing ⚠️
...components/metrics/sidebar/metrics_edit_inline.tsx 31.81% 15 Missing ⚠️
...c/components/metrics/redux/slices/metrics_slice.ts 84.94% 13 Missing and 1 partial ⚠️
public/components/metrics/view/metrics_grid.tsx 75.00% 8 Missing ⚠️
...ks/components/paragraph_components/para_output.tsx 88.05% 8 Missing ⚠️
public/components/visualizations/visualization.tsx 45.45% 6 Missing ⚠️
public/components/common/search/search.tsx 0.00% 5 Missing ⚠️
public/components/metrics/helpers/utils.tsx 58.33% 5 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1303      +/-   ##
==========================================
+ Coverage   56.42%   57.49%   +1.06%     
==========================================
  Files         327      330       +3     
  Lines       11930    12082     +152     
  Branches     2740     2789      +49     
==========================================
+ Hits         6732     6947     +215     
+ Misses       5153     5089      -64     
- Partials       45       46       +1     
Flag Coverage Δ
dashboards-observability 57.49% <63.16%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
@pjfitzgibbons pjfitzgibbons merged commit d16f2b2 into 2.x Dec 18, 2023
@pjfitzgibbons pjfitzgibbons deleted the feature/metrics-editor-and-promql-demo-nov6-141300-merge-to-2.x branch December 18, 2023 18:06
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-main
# Create a new branch
git switch --create backport/backport-1303-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d16f2b2edfe0085295ac237bbfc9905c55210839
# Push it to GitHub
git push --set-upstream origin backport/backport-1303-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1303-to-main.

@ps48
Copy link
Member

ps48 commented Dec 18, 2023

pjfitzgibbons added a commit that referenced this pull request Dec 18, 2023
* Metrics Explorer updated with PromQL

including query for Prometheus Metrics and updated Export Panel

---------

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
(cherry picked from commit d16f2b2)
Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
pjfitzgibbons added a commit that referenced this pull request Dec 18, 2023
* Metrics Explorer updated with PromQL

including query for Prometheus Metrics and updated Export Panel

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
pjfitzgibbons added a commit that referenced this pull request Dec 20, 2023
* Metrics Explorer updated with PromQL (#1303)

---------

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
* Metrics Explorer updated with PromQL

including query for Prometheus Metrics and updated Export Panel

---------

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
(cherry picked from commit d16f2b2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants