-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Match discover look and feel #1135
[Feature] Match discover look and feel #1135
Conversation
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
…cover, so that field type icons look the same and field action buttons disappear if not hovered over Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Eric look and feel
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
…her components Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
changed data grid sort page query logic, added sidebar drag drop, added viz config panel changes
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1135-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea2fb2c1669a229f4a58de145db81247eaec6b18
# Push it to GitHub
git push --set-upstream origin backport/backport-1135-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.11
# Create a new branch
git switch --create backport/backport-1135-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea2fb2c1669a229f4a58de145db81247eaec6b18
# Push it to GitHub
git push --set-upstream origin backport/backport-1135-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.11 Then, create a pull request where the |
* remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * move sidebar out of explorer for match look and feel Signed-off-by: Eric <menwe@amazon.com> * sidebar panel always with full height Signed-off-by: Eric <menwe@amazon.com> * adjust padding Signed-off-by: Eric <menwe@amazon.com> * make search components wrappable Signed-off-by: Eric <menwe@amazon.com> * adjust noresult/novisualize page Signed-off-by: Eric <menwe@amazon.com> * add padding to datagrid Signed-off-by: Eric <menwe@amazon.com> * restructured sidebar fields to use exact same spacing/paneling as discover, so that field type icons look the same and field action buttons disappear if not hovered over Signed-off-by: Paul Sebastian <paulstn@amazon.com> * address datasource persistency issue Signed-off-by: Eric <menwe@amazon.com> * code changes preparing for integration with app analytics Signed-off-by: Eric <menwe@amazon.com> * resolve page crash and hide datasource for app analytics Signed-off-by: Eric <menwe@amazon.com> * saved object supports datasources, query language, and direct query Signed-off-by: Eric <menwe@amazon.com> * change saved object icon Signed-off-by: Eric <menwe@amazon.com> * bulk delete for saved query Signed-off-by: Eric <menwe@amazon.com> * change data grid to separate sort/page query to not interfere with other components Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic drag and drop added Signed-off-by: Paul Sebastian <paulstn@amazon.com> * viz config changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add margin to resizable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * wrap countdistribution with panel Signed-off-by: Eric <menwe@amazon.com> * pr requested changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove panel wrapper for inner countdistribution Signed-off-by: Eric <menwe@amazon.com> * change datasource selector to only showopensearch/ default cluste Signed-off-by: Eric <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * url datasource data prsing and clean up Signed-off-by: Eric <menwe@amazon.com> * minor format Signed-off-by: Eric <menwe@amazon.com> * query bar issue when loading direct query saved object Signed-off-by: Eric <menwe@amazon.com> * minor cleanup Signed-off-by: Eric <menwe@amazon.com> * update snapshots Signed-off-by: Eric <menwe@amazon.com> * fix minor query bar issue and add types to searchMeta slice Signed-off-by: Eric <menwe@amazon.com> * stop polling when load from saved object and few related minor changes Signed-off-by: Eric <menwe@amazon.com> * fix polling cleanup issue Signed-off-by: Eric <menwe@amazon.com> * save will not trigger reload Signed-off-by: Eric <menwe@amazon.com> * add language enum Signed-off-by: Eric <menwe@amazon.com> * direct query status indicator Signed-off-by: Paul Sebastian <paulstn@amazon.com> * turn default timestamp/pattern mark to badge and on hover Signed-off-by: Paul Sebastian <paulstn@amazon.com> * flyout resize button margin fix Signed-off-by: Paul Sebastian <paulstn@amazon.com> * direct query data grid fixes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pr changes and added test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * removed console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * searchMetaData type change Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use datasource variable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed types and reduced redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed when data grix shows Signed-off-by: Paul Sebastian <paulstn@amazon.com> * simplify condition checking for datagrid Signed-off-by: Eric <menwe@amazon.com> * update snapshot Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit ea2fb2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * move sidebar out of explorer for match look and feel Signed-off-by: Eric <menwe@amazon.com> * sidebar panel always with full height Signed-off-by: Eric <menwe@amazon.com> * adjust padding Signed-off-by: Eric <menwe@amazon.com> * make search components wrappable Signed-off-by: Eric <menwe@amazon.com> * adjust noresult/novisualize page Signed-off-by: Eric <menwe@amazon.com> * add padding to datagrid Signed-off-by: Eric <menwe@amazon.com> * restructured sidebar fields to use exact same spacing/paneling as discover, so that field type icons look the same and field action buttons disappear if not hovered over Signed-off-by: Paul Sebastian <paulstn@amazon.com> * address datasource persistency issue Signed-off-by: Eric <menwe@amazon.com> * code changes preparing for integration with app analytics Signed-off-by: Eric <menwe@amazon.com> * resolve page crash and hide datasource for app analytics Signed-off-by: Eric <menwe@amazon.com> * saved object supports datasources, query language, and direct query Signed-off-by: Eric <menwe@amazon.com> * change saved object icon Signed-off-by: Eric <menwe@amazon.com> * bulk delete for saved query Signed-off-by: Eric <menwe@amazon.com> * change data grid to separate sort/page query to not interfere with other components Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic drag and drop added Signed-off-by: Paul Sebastian <paulstn@amazon.com> * viz config changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add margin to resizable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * wrap countdistribution with panel Signed-off-by: Eric <menwe@amazon.com> * pr requested changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove panel wrapper for inner countdistribution Signed-off-by: Eric <menwe@amazon.com> * change datasource selector to only showopensearch/ default cluste Signed-off-by: Eric <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * url datasource data prsing and clean up Signed-off-by: Eric <menwe@amazon.com> * minor format Signed-off-by: Eric <menwe@amazon.com> * query bar issue when loading direct query saved object Signed-off-by: Eric <menwe@amazon.com> * minor cleanup Signed-off-by: Eric <menwe@amazon.com> * update snapshots Signed-off-by: Eric <menwe@amazon.com> * fix minor query bar issue and add types to searchMeta slice Signed-off-by: Eric <menwe@amazon.com> * stop polling when load from saved object and few related minor changes Signed-off-by: Eric <menwe@amazon.com> * fix polling cleanup issue Signed-off-by: Eric <menwe@amazon.com> * save will not trigger reload Signed-off-by: Eric <menwe@amazon.com> * add language enum Signed-off-by: Eric <menwe@amazon.com> * direct query status indicator Signed-off-by: Paul Sebastian <paulstn@amazon.com> * turn default timestamp/pattern mark to badge and on hover Signed-off-by: Paul Sebastian <paulstn@amazon.com> * flyout resize button margin fix Signed-off-by: Paul Sebastian <paulstn@amazon.com> * direct query data grid fixes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pr changes and added test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * removed console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * searchMetaData type change Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use datasource variable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed types and reduced redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed when data grix shows Signed-off-by: Paul Sebastian <paulstn@amazon.com> * simplify condition checking for datagrid Signed-off-by: Eric <menwe@amazon.com> * update snapshot Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit ea2fb2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* remove unused files * missing snapshots * remove unused files * move sidebar out of explorer for match look and feel * sidebar panel always with full height * adjust padding * make search components wrappable * adjust noresult/novisualize page * add padding to datagrid * restructured sidebar fields to use exact same spacing/paneling as discover, so that field type icons look the same and field action buttons disappear if not hovered over * address datasource persistency issue * code changes preparing for integration with app analytics * resolve page crash and hide datasource for app analytics * saved object supports datasources, query language, and direct query * change saved object icon * bulk delete for saved query * change data grid to separate sort/page query to not interfere with other components * basic drag and drop added * viz config changes * add margin to resizable * wrap countdistribution with panel * pr requested changes * remove panel wrapper for inner countdistribution * change datasource selector to only showopensearch/ default cluste * remove unused files * missing snapshots * remove unused files * url datasource data prsing and clean up * minor format * query bar issue when loading direct query saved object * minor cleanup * update snapshots * fix minor query bar issue and add types to searchMeta slice * stop polling when load from saved object and few related minor changes * fix polling cleanup issue * save will not trigger reload * add language enum * direct query status indicator * turn default timestamp/pattern mark to badge and on hover * flyout resize button margin fix * direct query data grid fixes * pr changes and added test * removed console logs * searchMetaData type change * use datasource variable * fixed types and reduced redundancy * fixed when data grix shows * simplify condition checking for datagrid * update snapshot --------- (cherry picked from commit ea2fb2c) Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>
* remove unused files * missing snapshots * remove unused files * move sidebar out of explorer for match look and feel * sidebar panel always with full height * adjust padding * make search components wrappable * adjust noresult/novisualize page * add padding to datagrid * restructured sidebar fields to use exact same spacing/paneling as discover, so that field type icons look the same and field action buttons disappear if not hovered over * address datasource persistency issue * code changes preparing for integration with app analytics * resolve page crash and hide datasource for app analytics * saved object supports datasources, query language, and direct query * change saved object icon * bulk delete for saved query * change data grid to separate sort/page query to not interfere with other components * basic drag and drop added * viz config changes * add margin to resizable * wrap countdistribution with panel * pr requested changes * remove panel wrapper for inner countdistribution * change datasource selector to only showopensearch/ default cluste * remove unused files * missing snapshots * remove unused files * url datasource data prsing and clean up * minor format * query bar issue when loading direct query saved object * minor cleanup * update snapshots * fix minor query bar issue and add types to searchMeta slice * stop polling when load from saved object and few related minor changes * fix polling cleanup issue * save will not trigger reload * add language enum * direct query status indicator * turn default timestamp/pattern mark to badge and on hover * flyout resize button margin fix * direct query data grid fixes * pr changes and added test * removed console logs * searchMetaData type change * use datasource variable * fixed types and reduced redundancy * fixed when data grix shows * simplify condition checking for datagrid * update snapshot --------- (cherry picked from commit ea2fb2c) Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com>
…) (opensearch-project#1179)" This reverts commit b69801e.
…) (opensearch-project#1179)" This reverts commit b69801e. Signed-off-by: Eric <menwe@amazon.com>
* Revert "Update empty allowed roles to admin only (#1217) (#1220)" This reverts commit 4288504. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#1190)" This reverts commit ccd5fb8. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)" This reverts commit e0a509c. Signed-off-by: Eric <menwe@amazon.com> * Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)" This reverts commit ca5ad02. Signed-off-by: Eric <menwe@amazon.com> * Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)" This reverts commit 467a0b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Link integrations from datasources UI (#1203) (#1207)" This reverts commit 8e9fe5e. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)" This reverts commit f0e7a9d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Correct query schema for ELB mview generation (#1196) (#1199)" This reverts commit 0b7be95. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Backport 2.11] Add integrations queries for Flint (#1195)" This reverts commit 97f46ba. Signed-off-by: Eric <menwe@amazon.com> * Revert "remove husky pre-commit checks (#1192) (#1193)" This reverts commit 25d52f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)" This reverts commit e2440d2. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support cancellation of async queries (#1177) (#1186)" This reverts commit 6b495f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)" This reverts commit d50047f. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)" This reverts commit 95a60cc. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Feature] Match discover look and feel (#1135) (#1179)" This reverts commit b69801e. Signed-off-by: Eric <menwe@amazon.com> * Revert "config panel dark mode fix (#1169) (#1176)" This reverts commit 34696b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix events home table and toast life time (#1170)" This reverts commit a9b36fc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)" This reverts commit a2f9a00. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)" This reverts commit 9de9aea. Signed-off-by: Eric <menwe@amazon.com> * Revert "Remove loading progress for integration setup (#1156) (#1162)" This reverts commit a08721b. Signed-off-by: Eric <menwe@amazon.com> * Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)" This reverts commit e6a474a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Disable integration set up button if invalid (#1152) (#1161)" This reverts commit 74aae17. Signed-off-by: Eric <menwe@amazon.com> * Revert "Update URL of create datasources, fix spacing (#1149) (#1154)" This reverts commit 0b66d83. Signed-off-by: Eric <menwe@amazon.com> * Revert "Allow patch on allowedRoles (#1143) (#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "fix for explorer data grid not paginating (#1139) (#1141)" This reverts commit c5ead50. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
…nsearch-project#1180) * remove unused files * missing snapshots * remove unused files * move sidebar out of explorer for match look and feel * sidebar panel always with full height * adjust padding * make search components wrappable * adjust noresult/novisualize page * add padding to datagrid * restructured sidebar fields to use exact same spacing/paneling as discover, so that field type icons look the same and field action buttons disappear if not hovered over * address datasource persistency issue * code changes preparing for integration with app analytics * resolve page crash and hide datasource for app analytics * saved object supports datasources, query language, and direct query * change saved object icon * bulk delete for saved query * change data grid to separate sort/page query to not interfere with other components * basic drag and drop added * viz config changes * add margin to resizable * wrap countdistribution with panel * pr requested changes * remove panel wrapper for inner countdistribution * change datasource selector to only showopensearch/ default cluste * remove unused files * missing snapshots * remove unused files * url datasource data prsing and clean up * minor format * query bar issue when loading direct query saved object * minor cleanup * update snapshots * fix minor query bar issue and add types to searchMeta slice * stop polling when load from saved object and few related minor changes * fix polling cleanup issue * save will not trigger reload * add language enum * direct query status indicator * turn default timestamp/pattern mark to badge and on hover * flyout resize button margin fix * direct query data grid fixes * pr changes and added test * removed console logs * searchMetaData type change * use datasource variable * fixed types and reduced redundancy * fixed when data grix shows * simplify condition checking for datagrid * update snapshot --------- (cherry picked from commit ea2fb2c) Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit b2ff898)
Description
This PR contains changes for
To-dos with following PRs in progress related to this
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.