Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink source selector in t2v page #492

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Mar 7, 2025

Description

This PR is for shrink source selector in the t2v page when small screen. The root cause was the parent container still hold the extra space when using max-width: 30%. Change to a fixed width value can avoid this.

Before
https://github.com/user-attachments/assets/83e39478-7695-41d4-8446-36295b2406d3

After
https://github.com/user-attachments/assets/beb0ec80-b76c-4657-b904-292bd830dea8

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam changed the title Shrink source selector in small screen Shrink source selector in t2v page when small screen Mar 7, 2025
@wanglam wanglam changed the title Shrink source selector in t2v page when small screen Shrink source selector in t2v page Mar 7, 2025
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam marked this pull request as ready for review March 7, 2025 07:39
@wanglam wanglam merged commit cbac608 into opensearch-project:main Mar 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants