Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use agent framework API to generate answer #2

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

SuZhou-Joe
Copy link
Member

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe marked this pull request as draft November 1, 2023 09:40
*/
const agentFrameworkResponse = (await opensearchClient.transport.request({
method: 'POST',
path: '/_plugins/_ml/agents/_UoprosBZFp32K9Rsfqe/_execute',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we not hard code the agent id?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this PR is still in draft and we are waiting for AI-flow's API to give the root agent id back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joshuali925 , as the API returning root agent id is not ready yet, I will use a agentId from request body to unblock the PR to be merged.

ruanyl pushed a commit that referenced this pull request Nov 20, 2023
header entry icon update

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the feature/switch-chat-api branch from 5eb1064 to 7a335b6 Compare November 20, 2023 06:37
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review November 20, 2023 07:25
@SuZhou-Joe SuZhou-Joe merged commit 88eb43e into feature/agent-framework Nov 20, 2023
@SuZhou-Joe SuZhou-Joe deleted the feature/switch-chat-api branch December 1, 2023 03:14
raintygao pushed a commit to raintygao/dashboards-assistant that referenced this pull request Dec 1, 2023
* Added traces tooling

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Started new trace group tool

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Changed query get methods to not import from public

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Added tools for getting traces and services

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Cleaned up comments + removed broken services query

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Removed getServices import

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Deleted comments

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Converted output from tools to be in csv rather than JSON format

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Created flattenObject to convert data into csv

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Deleted print statements

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Updated description of traces tool

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Added unit testing for flattening objects

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Updated calls to use opensearchClient.search

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Removed unnecessary export

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

* Changed description

Signed-off-by: Daniel Dong <danieldong51@amazon.com>

---------

Signed-off-by: Daniel Dong <danieldong51@amazon.com>
Co-authored-by: Daniel Dong <danieldong51@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants