-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download certs from security repo #650
Download certs from security repo #650
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
It doesn't look like the CI check is working as expected:
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@finnegancarroll @mch2 This is ready for review. |
Testing locally the Regardless changes LGTM. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/asynchronous-search/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/asynchronous-search/backport-2.x
# Create a new branch
git switch --create backport/backport-650-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 63fa8d268a65b3fcfb2634b455696383dd61b2fb
# Push it to GitHub
git push --set-upstream origin backport/backport-650-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/asynchronous-search/backport-2.x Then, create a pull request where the |
* Download certs from security repo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused import Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix ci check Signed-off-by: Craig Perkins <cwperx@amazon.com> * Include setup-java step Signed-off-by: Craig Perkins <cwperx@amazon.com> * getParent Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove markAsSystemContext Signed-off-by: Craig Perkins <cwperx@amazon.com> * Configure basic auth header Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused imports Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update link to security repo Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 63fa8d2)
* Download certs from security repo (#650) * Download certs from security repo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused import Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix ci check Signed-off-by: Craig Perkins <cwperx@amazon.com> * Include setup-java step Signed-off-by: Craig Perkins <cwperx@amazon.com> * getParent Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove markAsSystemContext Signed-off-by: Craig Perkins <cwperx@amazon.com> * Configure basic auth header Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove unused imports Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update link to security repo Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 63fa8d2) * Remove unused imports Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
Download certs from security repo instead of having a local copy in this repo.
Testing out this same pattern that the sql plugin uses to reduce copies of the demo certs across plugin repos.
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.