remove rc1 qualifier #543
Merged
remove rc1 qualifier #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #543 +/- ##
=========================================
Coverage 79.07% 79.07%
Complexity 4207 4207
=========================================
Files 296 296
Lines 17681 17681
Branches 1877 1877
=========================================
+ Hits 13981 13982 +1
+ Misses 2801 2800 -1
Partials 899 899
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Same question: This is only for 2.0 branch? |
Should be for main branch and then backported to 2.0. We want main to be most up to date for all incoming development so we don't want to keep main to 2.0-rc1 while we have moved on to 2.0. |
ylwu-amzn
approved these changes
May 12, 2022
ohltyler
approved these changes
May 12, 2022
Zhangxunmt
approved these changes
May 12, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit dbd311a)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit dbd311a)
amitgalitz
added a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: Amit Galitzky <amgalitz@amazon.com> (cherry picked from commit dbd311a)
ylwu-amzn
pushed a commit
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky amgalitz@amazon.com
Description
remove rc1 qualifier and use of
_typein test as that field doesn't exist anymore for default index.Issues Resolved
resolves #536
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.