Adding more unit tests for validation API and some model classes #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69c175d to
15b53e1
Compare
Codecov Report
@@ Coverage Diff @@
## main #335 +/- ##
============================================
+ Coverage 77.54% 79.21% +1.66%
- Complexity 4018 4093 +75
============================================
Files 295 295
Lines 17188 17207 +19
Branches 1816 1826 +10
============================================
+ Hits 13329 13631 +302
+ Misses 3017 2676 -341
- Partials 842 900 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
reviewed
Dec 7, 2021
src/main/java/org/opensearch/ad/constant/CommonErrorMessages.java
Outdated
Show resolved
Hide resolved
| int totalHits = 9; | ||
| when(detectorResponse.getHits()).thenReturn(TestHelpers.createSearchHits(totalHits)); | ||
|
|
||
| // extend NodeClient since its execute method is final and mockito does not allow to mock final methods |
There was a problem hiding this comment.
There was a problem hiding this comment.
Changed this to use doAnswer instead of extending nodeClient
ylwu-amzn
reviewed
Dec 10, 2021
| @@ -73,8 +75,10 @@ public static String getTooManyCategoricalFieldErr(int limit) { | |||
| public static String HISTORICAL_ANALYSIS_CANCELLED = "Historical analysis cancelled by user"; | |||
| public static String HC_DETECTOR_TASK_IS_UPDATING = "HC detector task is updating"; | |||
| public static String NEGATIVE_TIME_CONFIGURATION = "should be non-negative"; | |||
| public static String INVALID_TIME_CONFIGURATION_UNITS = "Timezone %s is not supported"; | |||
There was a problem hiding this comment.
The error message seems not correct from the first release. Change to "Time unit %s is not supported" ?
There was a problem hiding this comment.
good catch! Changed this.
|
Link Checker failed, can you check and fix? |
Seems like this check has failed for the past week. After doing some research seems like a lot of other repos using the link-checker action have dropped the quotations mark surrounding args. A new PR from lychee-action team was released to add support for extra inputs. The new code adds quotes to the arguments so need to remove quotes we pass into args from now. |
ylwu-amzn
previously approved these changes
Dec 14, 2021
ohltyler
reviewed
Jan 3, 2022
src/test/java/org/opensearch/ad/model/ADEntityTaskProfileTests.java
Outdated
Show resolved
Hide resolved
ohltyler
reviewed
Jan 3, 2022
src/test/java/org/opensearch/ad/model/DetectorInternalStateTests.java
Outdated
Show resolved
Hide resolved
ohltyler
reviewed
Jan 3, 2022
src/test/java/org/opensearch/ad/transport/ValidateAnomalyDetectorTransportActionTests.java
Outdated
Show resolved
Hide resolved
63d8b2c to
51b3b1e
Compare
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
2102227 to
fac80e5
Compare
ohltyler
approved these changes
Jan 7, 2022
ylwu-amzn
approved these changes
Jan 7, 2022
ylwu-amzn
pushed a commit
to ylwu-amzn/anomaly-detection-2
that referenced
this pull request
Jan 11, 2022
…nsearch-project#335) Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
1 task
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 12, 2022
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added more unit testing for validation API as well as for some model classes that either didn't have any tests or were missing a unit test.
Split PR into two separate ones. This first one has all the additional validation testing, including some additional model testing. Second PR will have more integration tests, more tests in ad.model package and other files.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.