Implemented cross-cluster monitor support #1404

AWSHurneyt · 2024-02-05T20:53:05Z

Issue #, if available:
opensearch-project/alerting-dashboards-plugin#796

Description of changes:

Implemented support for cross-cluster cluster metrics monitors.
Implemented GetRemoteIndexes API to populate the frontend UI with details regarding the remote clusters, and indexes.

These changes are intended to enhance query, bucket, and cluster metrics monitors. As mentioned in the documentation issue (link), query and bucket monitors already support querying remote indexes; but configuring such monitors required using devtools/API commands. The enhancements in this PR allow users to configure remote using the frontend UI. In addition, these changes allow cluster metrics monitors to execute against remote clusters, which was not previously possible.

When this feature is enabled, the frontend will display a cluster selection dropdown for query, bucket, and cluster metrics monitors. The index selection dropdown will then display the indexes on the selected clusters. Alternatively for cluster metrics monitors, users can include a list of cluster name strings in the monitor input to create remote cluster metrics monitors via devtools/API commands.

Documentation PR for reference opensearch-project/documentation-website#6350

CheckList:

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…onitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…mented GetRemoteIndexes API to populate the frontend UI with details regarding the remote clusters, and indexes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt · 2024-02-05T20:55:08Z

Successfully building this PR will depend on merging the common utils changes, and publishing maven.
opensearch-project/common-utils#584

bowenlan-amzn · 2024-02-06T00:31:04Z

@AWSHurneyt can you fix the workflow

For the description, can you add how would user use this feature? and a quick walkthrough of the implementation idea.

eirsep · 2024-02-06T00:38:40Z

alerting/src/main/kotlin/org/opensearch/alerting/AlertService.kt

@@ -190,6 +191,19 @@ class AlertService(
            )
        }

+        // Including a list of triggered clusters for cluster metrics monitors
+        var triggeredClusters: MutableList<String>? = null
+        if (result is ClusterMetricsTriggerRunResult)


composeQueryLevelAlert() method is now checking for ClusterMetricsTriggerRunResult?

isnt cluster metrics a separate kind of monitpr?

should we not add triggered clusters metric to all monitor types' alerts?

Correct. Cluster metrics monitors started out as query level monitors before we added additional monitor types when we introduced bucket level monitors. Their alerts were handled in a similar way up until this point, so I added this check in composeQueryLevelAlert rather than duplicate the code elsewhere.

AWSHurneyt · 2024-02-06T00:52:32Z

@AWSHurneyt can you fix the workflow

For the description, can you add how would user use this feature? and a quick walkthrough of the implementation idea.

@bowenlan-amzn I added some more details to the description.

eirsep · 2024-02-06T01:02:35Z

alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestGetRemoteIndexesAction.kt

+
+private val log = LogManager.getLogger(RestGetRemoteIndexesAction::class.java)
+
+class RestGetRemoteIndexesAction : BaseRestHandler() {


javadocs and code comments

eirsep · 2024-02-06T01:02:45Z

alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestGetRemoteIndexesAction.kt

+private val log = LogManager.getLogger(RestGetRemoteIndexesAction::class.java)
+
+class RestGetRemoteIndexesAction : BaseRestHandler() {
+    val ROUTE = "${AlertingPlugin.REMOTE_BASE_URI}/indexes"


I went with indexes because we had this issue a while back in which we were moving away from indices.
opensearch-project/index-management-dashboards-plugin#637

eirsep · 2024-02-06T01:04:31Z

alerting/src/main/kotlin/org/opensearch/alerting/AlertingPlugin.kt

@@ -183,7 +187,8 @@ internal class AlertingPlugin : PainlessExtension, ActionPlugin, ScriptPlugin, R
            RestGetWorkflowAlertsAction(),
            RestGetFindingsAction(),
            RestGetWorkflowAction(),
-            RestDeleteWorkflowAction()
+            RestDeleteWorkflowAction(),
+            RestGetRemoteIndexesAction(),


I went with indexes because we had this issue a while back in which we were moving away from indices.
opensearch-project/index-management-dashboards-plugin#637

eirsep · 2024-02-06T01:47:22Z

why are we adding support to fetch remote indices in alerting plugin? isn't that a core feature?

AWSHurneyt · 2024-02-06T02:15:13Z

why are we adding support to fetch remote indices in alerting plugin? isn't that a core feature?

@eirsep The GetRemoteIndexes API is used to gather details about the clusters and their indexes to display in the frontend. The frontend plugins do not have access to remoteClients to make most API calls against the remote clusters.

bowenlan-amzn · 2024-02-06T00:50:15Z

alerting/src/main/kotlin/org/opensearch/alerting/util/IndexUtils.kt

                    IndicesOptions.lenientExpand(),
                    true,
                    index
                )
                result.addAll(concreteIndices)
            }

+            if (result.size == 0) {
+                throw IndexNotFoundException(indices[0])


I feel you want to do this above before result.addAll(concreteIndices)?
if concreteIndices is empty, throw exception?

Looks like this was implemented in PR #784.

@eirsep @sbcd90 do you recall if there was a particular reason why we considering throwing the exception after attempting to resolve all of the indexes? Would it be better to throw the exception if even 1 index failed to have any concrete indexes?

🤔 now I don't understand why this code shows up here like you added this...

And adding on your question, why only shows indices[0] but not indices

bowenlan-amzn · 2024-02-06T01:36:05Z

alerting/src/main/kotlin/org/opensearch/alerting/transport/TransportGetRemoteIndexesAction.kt

+        client.threadPool().threadContext.stashContext().use {
+            scope.launch {
+                val singleThreadContext = newSingleThreadContext("GetRemoteIndexesActionThread")
+                withContext(singleThreadContext) {


For your reference, this is how ISM does the user role injection

https://github.com/opensearch-project/index-management/blob/ba24f862a4b59bdac5a4def76033766346e9eea8/src/main/kotlin/org/opensearch/indexmanagement/opensearchapi/OpenSearchExtensions.kt#L280-L322

And seems QueryLevelMonitorRunner also does withClosableContext in it

Ah interesting. It looks like on this line ISM checks whether the user info is in the context, and injects it if not. Craig and I discussed doing something similar last week, but landed on the single thread implementation since we want to ensure the actions performed by the API take place in a specific sequence. Do you have any insight into the pros and cons of ISM's approach?
https://github.com/opensearch-project/index-management/blob/ba24f862a4b59bdac5a4def76033766346e9eea8/src/main/kotlin/org/opensearch/indexmanagement/opensearchapi/OpenSearchExtensions.kt#L300

I think using ThreadContextElement is more natural to kotlin coroutine, since it's provided directly by them.
Basically what it does is to attach this element to the coroutine that will execute your code.

While force the user info in one thread, I feel it's possible that this thread may be used to execute other coroutine? then it may cause some problem.

bowenlan-amzn · 2024-02-06T02:00:11Z

alerting/src/main/kotlin/org/opensearch/alerting/util/CrossClusterMonitorUtils.kt

+        /**
+         * The [NodeClient] used by the plugin cannot execute searches against local indexes
+         * using format "<LOCAL_CLUSTER_NAME>:<INDEX_NAME>". That format only supports querying remote indexes.
+         * This function formats a list of indexes to be supplied directly to a [SearchRequest].
+         * @param indexes A list of index names in "<CLUSTER_NAME>:<INDEX_NAME>" format.
+         * @param localClusterName The name of the local cluster.
+         * @return A list of indexes with any remote indexes in "<CLUSTER_NAME>:<INDEX_NAME>" format,
+         *      and any local indexes in "<INDEX_NAME>" format.
+         */
+        @JvmStatic
+        fun parseIndexesForRemoteSearch(indexes: List<String>, localClusterName: String): List<String> {
+            return indexes.map {
+                var index = it
+                val clusterName = parseClusterName(it)
+                if (clusterName.isNotEmpty() && clusterName == localClusterName) {
+                    index = parseIndexName(it)
+                }
+                index
+            }
+        }


This method is confusing to me, in the end it seems only useful to user input <local cluster name>:<index> and transform it in to <index>
Instead of doing such thing, why not just let it fail?

If the local cluster is named cluster-1, and a monitor input is configured with indexes ["cluster-1:index-1","cluster-2:index-2"], the node client of the local cluster will not be able to query the first index because the pattern references the local cluster name. This function will parse that list of indexes to ["index-1","cluster-2:index-2"] so it can be successfully fed into the node client.

Yeah, I get this function. The confusing part is why we want to support user to use local cluster name in the input, does the other feature from UI also support that?

I wanted to cover cases where a user may do this without knowing.

If user cannot do it in other place, this should also be forbidden here.
So to decide, try do a search call in a cross cluster environment with <local cluster name>:<index> on a local index, and see if that works. If so, this is ok.

bowenlan-amzn · 2024-02-06T02:09:04Z

alerting/src/main/kotlin/org/opensearch/alerting/QueryLevelMonitorRunner.kt

+                    val remoteMonitoringEnabled = monitorCtx.clusterService!!.clusterSettings.get(AlertingSettings.REMOTE_MONITORING_ENABLED)
+                    logger.debug("Remote monitoring enabled: {}", remoteMonitoringEnabled)
+                    if (remoteMonitoringEnabled) monitorCtx.triggerService!!.runClusterMetricsTrigger(monitor, trigger, triggerCtx, monitorCtx.clusterService!!)
+                    else monitorCtx.triggerService!!.runQueryLevelTrigger(monitor, trigger, triggerCtx)


Just curious, why cluster metric monitor run query level trigger?

Cluster metrics monitors were initially query level monitors before bucket level introduced monitor types. If I remember correctly, we gave cluster metrics monitors a unique type around the implementation of doc level monitors. It could be nice to eventually give cluster metrics monitors their own assets like runner, and trigger; but at the time, their execution was so similar to query level, we didn't change them.

bowenlan-amzn · 2024-02-06T02:16:29Z

alerting/src/main/kotlin/org/opensearch/alerting/AlertService.kt

@@ -190,6 +191,19 @@ class AlertService(
            )
        }

+        // Including a list of triggered clusters for cluster metrics monitors
+        var triggeredClusters: MutableList<String>? = null


Consider this is for experiemental, does here need a check for cluster setting for this feature?

I don't think that would be necessary, as the feature disabled, this will always be just the local cluster. But I'm open adding a setting check if we think that's best.

… a data class to an open class for inheritability. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

getsaurabh02

Lets follow up on test failures via opening separate issues

eirsep · 2024-02-06T08:39:39Z

have we made changes in security plugin?

eirsep · 2024-02-06T08:58:54Z

no integ tests added to verify end to end behaviour?

AWSHurneyt · 2024-02-06T18:36:51Z

have we made changes in security plugin?

No, we didn't need to make any changes in the security plugin.

AWSHurneyt · 2024-02-06T18:39:38Z

no integ tests added to verify end to end behaviour?

This is not ideal, but so far testing has all been manual. I have implementing feature-specific tests as a fast follow-up item. For some additional context, query and bucket monitors already supported remote index querying. The major change in this PR is supporting remote calls for cluster metrics monitors.

AWSHurneyt · 2024-02-06T18:49:07Z

CVE PR #1405 adjusted the ktlint version, which is causing style failures upon rerunning the tests now that the PR opensearch-project/common-utils#584 changes have been published to maven. Cleaning up those errors.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt · 2024-02-06T22:03:41Z

Lets follow up on test failures via opening separate issues

All tests are passing now. Merging in these changes.

opensearch-trigger-bot · 2024-02-06T22:04:02Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1404-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea36996616eb91b2547b6a64274bbd9e50b1af5d
# Push it to GitHub
git push --set-upstream origin backport-1404-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport-1404-to-2.x.

* Updated alert mappings to accommodate cross-cluster cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented support for cross-cluster cluster metrics monitors. Implemented GetRemoteIndexes API to populate the frontend UI with details regarding the remote clusters, and indexes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a writeable test after changing QueryLevelTriggerRunResult from a data class to an open class for inheritability. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed changes to IndexUtils as they're only needed by doc monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit ea36996) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Implemented cross-cluster monitor support (#1404) * Updated alert mappings to accommodate cross-cluster cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented support for cross-cluster cluster metrics monitors. Implemented GetRemoteIndexes API to populate the frontend UI with details regarding the remote clusters, and indexes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a writeable test after changing QueryLevelTriggerRunResult from a data class to an open class for inheritability. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed changes to IndexUtils as they're only needed by doc monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit ea36996) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

…ject#1307) * Added 2.11.1 release notes. * Added 2.11.1 release notes. --------- (cherry picked from commit 06c1b8a) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> fix workflow security tests in alerting (opensearch-project#1310) (opensearch-project#1311) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Increment version to 2.12.0-SNAPSHOT (opensearch-project#1239) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> [Backport 2.x] Reference get monitor and search monitor action / request / responses from common-utils (opensearch-project#1315) * Use get monitor action / req / resp from common-utils Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Dummy commit to retrigger Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> optimize doc-level monitor execution workflow for datastreams (opensearch-project#1302) (opensearch-project#1322) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Update to Gradle 8.5 (opensearch-project#1369) (opensearch-project#1371) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> [Backport 2.x] Inject namedWriteableRegistry during ser/deser of SearchMonitorAction (opensearch-project#1382) (opensearch-project#1384) * Inject namedWriteableRegistry during ser/deser of SearchMonitorAction (opensearch-project#1382) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove bin files Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * remove core bin Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Don't attempt to parse workflow if it doesn't exist (opensearch-project#1346) (opensearch-project#1359) (cherry picked from commit 733fd4e) Signed-off-by: Chase Engelbrecht <engechas@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Set docData to empty string if actual is null (opensearch-project#1325) (opensearch-project#1334) (cherry picked from commit 008e076) Signed-off-by: Chase Engelbrecht <engechas@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> removed default admin credentials for alerting (opensearch-project#1399) (opensearch-project#1400) (cherry picked from commit 3c50f7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com> ipaddress lib upgrade as part of cve fix (opensearch-project#1397) (opensearch-project#1407) (cherry picked from commit 8d59060) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Bulk index findings and sequentially invoke auto-correlations (opensearch-project#1355) (opensearch-project#1410) * Bulk index findings and sequentially invoke auto-correlations * Bulk index findings in batches of 10000 and make it configurable * Addressing review comments * Add integ tests to test bulk index findings * Fix ktlint formatting --------- (cherry picked from commit b561965) Signed-off-by: Megha Goyal <goyamegh@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Add 2.12 release notes (opensearch-project#1408) (opensearch-project#1413) * Add 2.12 release notes * Fix release notes PR * Add 2 more PRs --------- (cherry picked from commit b10eaad) Signed-off-by: Chase Engelbrecht <engechas@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> [Backport 2.x] Implemented cross-cluster monitor support (opensearch-project#1404) (opensearch-project#1412) * Implemented cross-cluster monitor support (opensearch-project#1404) * Updated alert mappings to accommodate cross-cluster cluster metrics monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Implemented support for cross-cluster cluster metrics monitors. Implemented GetRemoteIndexes API to populate the frontend UI with details regarding the remote clusters, and indexes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a writeable test after changing QueryLevelTriggerRunResult from a data class to an open class for inheritability. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Removed changes to IndexUtils as they're only needed by doc monitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit ea36996) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Fixed a test. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Add publishToMavenLocal in build.sh (opensearch-project#1418) (opensearch-project#1419) (cherry picked from commit 4cdc1d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> fix for MapperException[the [enabled] parameter can't be updated for the object mapping [metadata.source_to_query_index_mapping] (opensearch-project#1432) (opensearch-project#1434) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> bacport PRs opensearch-project#1445, opensearch-project#1430, opensearch-project#1441, opensearch-project#1435 to 2.x (opensearch-project#1452) * Add jvm aware setting and max num docs settings for batching docs for percolate queries (opensearch-project#1435) * add jvm aware and max docs settings for batching docs for percolate queries Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix stats logging Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add queryfieldnames field in findings mapping Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * optimize to fetch only fields relevant to doc level queries in doc level monitor instead of entire _source for each doc (opensearch-project#1441) * optimize to fetch only fields relevant to doc level queries in doc level monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix test for settings check Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix ktlint Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * clean up doc level queries on dry run (opensearch-project#1430) Signed-off-by: Joanne Wang <jowg@amazon.com> * optimize sequence number calculation and reduce search requests in doc level monitor execution (opensearch-project#1445) * optimize sequence number calculation and reduce search requests by n where n is number of shards being queried in the executino Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix tests Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * optimize check indices and execute to query only write index of aliases and datastreams during monitor creation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix test Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add javadoc Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add tests to verify seq_no calculation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Joanne Wang <jowg@amazon.com> Co-authored-by: Joanne Wang <jowg@amazon.com> [Backport 2.x] Add an _exists_ check to document level monitor queries (opensearch-project#1425) (opensearch-project#1456) * Add an _exists_ check to document level monitor queries (opensearch-project#1425) * clean up and add integ tests Signed-off-by: Joanne Wang <jowg@amazon.com> * refactored out common method and renamed test Signed-off-by: Joanne Wang <jowg@amazon.com> * remove _exists_ flag Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> * fix integ test Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> add distributed locking to jobs in alerting (opensearch-project#1403) (opensearch-project#1458) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

AWSHurneyt added 2 commits February 5, 2024 11:29

Updated alert mappings to accommodate cross-cluster cluster metrics m…

1181cb5

…onitors. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Implemented support for cross-cluster cluster metrics monitors. Imple…

8f3a9ea

…mented GetRemoteIndexes API to populate the frontend UI with details regarding the remote clusters, and indexes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt added backport 2.x cross-cluster-monitor labels Feb 5, 2024

AWSHurneyt requested review from lezzago, sbcd90, eirsep, getsaurabh02, praveensameneni, qreshi, bowenlan-amzn and rishabhmaurya as code owners February 5, 2024 20:53

AWSHurneyt mentioned this pull request Feb 5, 2024

Implemented cross-cluster monitors. opensearch-project/alerting-dashboards-plugin#871

Merged

5 tasks

praveensameneni approved these changes Feb 6, 2024

View reviewed changes

eirsep reviewed Feb 6, 2024

View reviewed changes

bowenlan-amzn reviewed Feb 6, 2024

View reviewed changes

AWSHurneyt mentioned this pull request Feb 6, 2024

Refactored alert tests opensearch-project/security-analytics#837

Merged

5 tasks

Fixed a writeable test after changing QueryLevelTriggerRunResult from…

36482bb

… a data class to an open class for inheritability. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

praveensameneni approved these changes Feb 6, 2024

View reviewed changes

amsiglan approved these changes Feb 6, 2024

View reviewed changes

getsaurabh02 approved these changes Feb 6, 2024

View reviewed changes

AWSHurneyt added 2 commits February 6, 2024 10:49

Merge branch 'opensearch-project:main' into 3.0-cross-cluster-dev

7113fa3

Fixed ktlint errors.

4b907b9

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

praveensameneni approved these changes Feb 6, 2024

View reviewed changes

AWSHurneyt added 2 commits February 6, 2024 11:42

Merge branch 'main' into 3.0-cross-cluster-dev

885545f

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

Removed changes to IndexUtils as they're only needed by doc monitors.

54925c5

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

AWSHurneyt merged commit ea36996 into opensearch-project:main Feb 6, 2024
18 checks passed

opensearch-trigger-bot bot added the failed backport label Feb 6, 2024

AWSHurneyt mentioned this pull request Feb 6, 2024

[Backport 2.x] Implemented cross-cluster monitor support (#1404) #1412

Merged

1 task

AWSHurneyt mentioned this pull request Feb 7, 2024

Show aliases in data source options for detector and correlation rule creation opensearch-project/security-analytics-dashboards-plugin#864

Merged

1 task

AWSHurneyt removed the failed backport label Mar 20, 2024

AWSHurneyt deleted the 3.0-cross-cluster-dev branch April 3, 2024 21:43


		private val log = LogManager.getLogger(RestGetRemoteIndexesAction::class.java)

		class RestGetRemoteIndexesAction : BaseRestHandler() {

Implemented cross-cluster monitor support #1404

Implemented cross-cluster monitor support #1404

Conversation

AWSHurneyt commented Feb 5, 2024 • edited Loading

AWSHurneyt commented Feb 5, 2024

bowenlan-amzn commented Feb 6, 2024

eirsep Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AWSHurneyt commented Feb 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eirsep commented Feb 6, 2024

AWSHurneyt commented Feb 6, 2024

bowenlan-amzn Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

getsaurabh02 left a comment

Choose a reason for hiding this comment

eirsep commented Feb 6, 2024

eirsep commented Feb 6, 2024

AWSHurneyt commented Feb 6, 2024

AWSHurneyt commented Feb 6, 2024

AWSHurneyt commented Feb 6, 2024 • edited Loading

AWSHurneyt commented Feb 6, 2024

opensearch-trigger-bot bot commented Feb 6, 2024

AWSHurneyt commented Feb 5, 2024 •

edited

Loading

eirsep Feb 6, 2024 •

edited

Loading

bowenlan-amzn Feb 6, 2024 •

edited

Loading

AWSHurneyt commented Feb 6, 2024 •

edited

Loading