-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PR to enable MDS support for Monitors and Alerts Triggers within the Alerting Plugin. #949
Initial PR to enable MDS support for Monitors and Alerts Triggers within the Alerting Plugin. #949
Conversation
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
public/pages/CreateMonitor/containers/DefineMonitor/DefineMonitor.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming CI passes.
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
public/pages/MonitorDetails/containers/MonitorHistory/MonitorHistory.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
==========================================
- Coverage 48.70% 48.42% -0.28%
==========================================
Files 236 237 +1
Lines 6852 6990 +138
Branches 997 1017 +20
==========================================
+ Hits 3337 3385 +48
- Misses 3512 3602 +90
Partials 3 3 ☔ View full report in Codecov by Sentry. |
da99e39
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-949-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da99e39c830e5e50b2e4ab314366d87e8f8a8cdc
# Push it to GitHub
git push --set-upstream origin backport-949-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.x Then, create a pull request where the |
…hin the Alerting Plugin. (opensearch-project#949) * first setup for alerting MDS support Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed some create-monitor issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed create Monitor Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed monitor actions for mds support Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix jest tests and added neo support for alertTriggers Signed-off-by: Riya Saxena <riysaxen@amazon.com> * minor bug fixes Signed-off-by: Riya Saxena <riysaxen@amazon.com> * minor bug fixes Signed-off-by: Riya Saxena <riysaxen@amazon.com> * remve dev code Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the comments by fixing minor issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the comments by fixing minor issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the review comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit da99e39)
…hin the Alerting Plugin. (#949) (#968) * first setup for alerting MDS support Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed some create-monitor issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed create Monitor Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fixed monitor actions for mds support Signed-off-by: Riya Saxena <riysaxen@amazon.com> * fix jest tests and added neo support for alertTriggers Signed-off-by: Riya Saxena <riysaxen@amazon.com> * minor bug fixes Signed-off-by: Riya Saxena <riysaxen@amazon.com> * minor bug fixes Signed-off-by: Riya Saxena <riysaxen@amazon.com> * remve dev code Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the comments by fixing minor issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the comments by fixing minor issues Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> * address the review comments Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com> (cherry picked from commit da99e39) Signed-off-by: Riya <69919272+riysaxen-amzn@users.noreply.github.com>
Description
Data Source
toSelect data
in createMonitor pageData Source
toIndex
in viewMonitor pageTesting
Monitors
monitorsNeo12.mov
neoMonitors13.mov
Associate Monitors and Alert Triggers
neoAssociateAndAlerts.mov
Issue
879
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.