Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few bug fix for create monitor #121

Closed
wants to merge 20 commits into from

Conversation

annie3431
Copy link
Contributor

@annie3431 annie3431 commented Sep 30, 2021

Description

  • Fix the problem of bucket level monitor preview graph not showing up when minDate equals to maxDate.
  • A few text update.
  • Fix the bug when bucket-level monitor metrics fields contains '.', the data won't show correctly in preview graph. Added a parsing function to parse '.' to '_'.
  • Update validation of numeric fields to show error message if input is a string type value.
  • Removing a redundant comma in bucket-level alerting graph.
  • Allow bulk acknowledge to alerts.
  • Additional validation on query definition combo boxes to ensure no additional values are provided when switching monitor type.
  • Additional validation on query definition combo boxes to ensure empty values are not passed in.
  • Remove "Acknowledge" action option on monitors page when selecting multiple monitors.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

annie3431 and others added 3 commits September 30, 2021 15:55
* Update .opensearch_dashboards-plugin-helpers.json

* Update snapshots

* Update whereExpression.test and some snapshots

* Update whereExpression.test and some snapshots

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update snapshots

* Update formikToTrigger.test.js

* Update formikToTrigger.test.js

* Update formikToTrigger.test.js

* Add icon tooltip

* Add test

* Update tests

* remove license

* Update TriggerExpressions.test.js

* Update Triggers.test.js

* Update validation test

* Update getOverviewStats.test.js

* Update validate.test.js

* Update helpers.test.js and remove unused import

* Update Triggers.test.js

* Update helpers.js

* Update CreateMonitor test and clean up code

* Update CreateMonitor test and clean up code

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Update release note and adding more tests

* Add test and modify cypress common-utils branch

* Update MonitorDefinitionCard.test.js.snap

* Update cypress-workflow.yml

Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
Signed-off-by: Annie Lee <leeyun@amazon.com>
@annie3431 annie3431 added the bug Something isn't working label Sep 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #121 (340e5e5) into main (ae78928) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   50.93%   50.89%   -0.05%     
==========================================
  Files         200      200              
  Lines        4639     4659      +20     
  Branches      586      592       +6     
==========================================
+ Hits         2363     2371       +8     
- Misses       2274     2286      +12     
  Partials        2        2              
Impacted Files Coverage Δ
...nitors/components/MonitorActions/MonitorActions.js 88.46% <0.00%> (-11.54%) ⬇️
...MonitorExpressions/expressions/MetricExpression.js 74.07% <0.00%> (-1.93%) ⬇️
...onitorExpressions/expressions/GroupByExpression.js 75.00% <0.00%> (-1.93%) ⬇️
...ateMonitor/components/VisualGraph/utils/helpers.js 46.23% <0.00%> (-1.55%) ⬇️
...lerting-dashboards-plugin/public/utils/validate.js 68.65% <0.00%> (-1.50%) ⬇️
...gin/public/pages/Dashboard/containers/Dashboard.js 66.37% <0.00%> (ø)
...nents/MonitorExpressions/expressions/MetricItem.js 0.00% <0.00%> (ø)
...ents/MonitorExpressions/expressions/GroupByItem.js 0.00% <0.00%> (ø)
.../MonitorExpressions/expressions/utils/constants.js 100.00% <0.00%> (ø)
.../MonitorExpressions/expressions/WhereExpression.js 70.14% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae78928...340e5e5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants