Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10] Disable remote integrity check for encrypted repos for ChecksumBlobstoreFormat #9924

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 967ef31 from #9908.

…oreFormat (#9908)

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit 967ef31)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change 349d575

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@linuxpi
Copy link
Collaborator

linuxpi commented Sep 8, 2023

different test failure in both runs

Run #1 https://build.ci.opensearch.org/job/gradle-check/25118/

org.opensearch.snapshots.DeleteSnapshotIT.testDeleteMultipleShallowCopySnapshotsCase1

ran locally on source branch and it did not fail, seems flaky
./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.DeleteSnapshotIT.testDeleteMultipleShallowCopySnapshotsCase1" -Dtests.iters=5

Run #2 https://build.ci.opensearch.org/job/gradle-check/25123/
org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

ran locally on source branch and it did not fail, seems flaky
./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock" -Dtests.iters=5

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testContainerCreationAndDeletion

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #9924 (349d575) into 2.10 (311e3de) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               2.10    #9924      +/-   ##
============================================
+ Coverage     70.76%   70.85%   +0.09%     
- Complexity    58184    58269      +85     
============================================
  Files          4817     4817              
  Lines        275285   275286       +1     
  Branches      40445    40445              
============================================
+ Hits         194807   195067     +260     
+ Misses        63781    63545     -236     
+ Partials      16697    16674      -23     
Files Changed Coverage Δ
...epositories/blobstore/ChecksumBlobStoreFormat.java 95.00% <100.00%> (+0.08%) ⬆️

... and 452 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 6729882 into 2.10 Sep 8, 2023
@github-actions github-actions bot deleted the backport/backport-9908-to-2.10 branch September 8, 2023 10:00
@DarshitChanpura
Copy link
Member

@gbbafna This is merged after code freeze for 2.10 which was Sept 7. This change should be reverted unless is planned and communicated.

@gbbafna
Copy link
Collaborator

gbbafna commented Sep 8, 2023

@DarshitChanpura This is planned and communicated as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants