Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize tests for concurrent search 2 #9852

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Parameterize tests for concurrent search 2 #9852

merged 1 commit into from
Sep 13, 2023

Conversation

neetikasinghal
Copy link
Contributor

@neetikasinghal neetikasinghal commented Sep 6, 2023 •
edited
Loading

Description

Parameterizing first batch of ITs with concurrent search enabled as part of this PR.
List of ITs Parameterized in this PR:

  1. ScriptedMetricIT.java
  2. CardinalityIT.java
  3. StatsIT.java
  4. SumIT.java
  5. TDigestPercentilesIT.java
  6. TopHitsIT.java
  7. HDRPercentilesIT.java
  8. HDRPercentileRanksIT.java
  9. MedianAbsoluteDeviationIT.java
  10. TDigestPercentileRanksIT.java
  11. ValueCountIT.java
  12. ExtendedStatsIT.java
  13. BucketSortIT.java
  14. AvgBucketIT.java
  15. SerialDiffIT.java
  16. ExtendedStatsBucketIT.java
  17. PercentilesBucketIT.java
  18. DateDerivativeIT.java
  19. MovAvgIT.java
  20. SumBucketIT.java
  21. StatsBucketIT.java
  22. MaxBucketIT.java
  23. MinBucketIT.java
  24. BucketSelectorIT.java
  25. BucketScriptIT.java
  26. DerivativeIT.java
  27. AggregationsIntegrationIT.java
  28. MissingValueIT.java
  29. CombiIT.java
  30. MetadataIT.java
  31. DoubleTermsIT.java
  32. HistogramIT.java
  33. SamplerIT.java
  34. ShardReduceIT.java
  35. FilterIT.java
  36. TermsDocCountErrorIT.java
  37. ReverseNestedIT.java
  38. NestedIT.java
  39. SignificantTermsSignificanceScoreIT.java
  40. LongTermsIT.java
  41. NaNSortingIT.java
  42. MultiTermsIT.java
  43. GlobalIT.java
  44. StringTermsIT.java
  45. BaseStringTermsTestCase.java
  46. GeoDistanceIT.java
  47. IpRangeIT.java
  48. MinDocCountIT.java
  49. BooleanTermsIT.java
  50. FiltersIT.java
  51. DateRangeIT.java
  52. DiversifiedSamplerIT.java
  53. RangeIT.java
  54. AbstractTermsTestCase.java
  55. AbstractNumericTestCase.java

Related Issues

Resolves #9443

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 8090a9d

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change c592730

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

#1703 - flaky

#9907 - flaky

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Sep 11, 2023 

[org.opensearch.search.aggregations.bucket.DateRangeIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/DateRangeIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.DateRangeIT.testRangeWithFormatStringValue {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/DateRangeIT/testRangeWithFormatStringValue__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.DateRangeIT.testRangeWithFormatNumericValue {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/DateRangeIT/testRangeWithFormatNumericValue__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.DoubleTermsIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/DoubleTermsIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.HistogramIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/HistogramIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.HistogramIT.testHardBounds {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/HistogramIT/testHardBounds__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.HistogramIT.testDecimalIntervalAndOffset {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/HistogramIT/testDecimalIntervalAndOffset__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.LongTermsIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/LongTermsIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.NestedIT.testExtractInnerHitBuildersWithDuplicatePath {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/NestedIT/testExtractInnerHitBuildersWithDuplicatePath__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.NestedIT.testExtractInnerHitBuildersWithDuplicateHitName {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/NestedIT/testExtractInnerHitBuildersWithDuplicateHitName__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.NestedIT.testFilterAggInsideNestedAgg {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/NestedIT/testFilterAggInsideNestedAgg__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.NestedIT.testParentFilterResolvedCorrectly {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/NestedIT/testParentFilterResolvedCorrectly__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.NestedIT.testNestedSameDocIdProcessedMultipleTime {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/NestedIT/testNestedSameDocIdProcessedMultipleTime__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.RangeIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/RangeIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.ReverseNestedIT.testSameParentDocHavingMultipleBuckets {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket/ReverseNestedIT/testSameParentDocHavingMultipleBuckets__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.bucket.terms.StringTermsIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.bucket.terms/StringTermsIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.CardinalityIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/CardinalityIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.ExtendedStatsIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/ExtendedStatsIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.HDRPercentileRanksIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/HDRPercentileRanksIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.HDRPercentilesIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/HDRPercentilesIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.MedianAbsoluteDeviationIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/MedianAbsoluteDeviationIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.ScriptedMetricIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/ScriptedMetricIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.StatsIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/StatsIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.SumIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/SumIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.TDigestPercentileRanksIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/TDigestPercentileRanksIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.TDigestPercentilesIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/TDigestPercentilesIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.metrics.ValueCountIT.testScriptCaching {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.metrics/ValueCountIT/testScriptCaching__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.pipeline.DerivativeIT.testAvgMovavgDerivNPE {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.pipeline/DerivativeIT/testAvgMovavgDerivNPE__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.pipeline.MaxBucketIT.testFieldIsntWrittenOutTwice {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.pipeline/MaxBucketIT/testFieldIsntWrittenOutTwice__p0___search_concurrent_segment_search_enabled___true___/)
[org.opensearch.search.aggregations.pipeline.MovAvgIT.testPredictWithNonEmptyBuckets {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/25288/testReport/junit/org.opensearch.search.aggregations.pipeline/MovAvgIT/testPredictWithNonEmptyBuckets__p0___search_concurrent_segment_search_enabled___true___/)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #9852 (8090a9d) into main (bc40428) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9852      +/-   ##
============================================
- Coverage     71.23%   71.17%   -0.07%     
+ Complexity    58186    58142      -44     
============================================
  Files          4824     4824              
  Lines        273915   273915              
  Branches      39917    39917              
============================================
- Hits         195118   194948     -170     
- Misses        62502    62609     +107     
- Partials      16295    16358      +63

see 422 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Parameterize tests for concurrent search 2
8090a9d 
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor Author

@sohami /@reta can u please merge this?

@sohami sohami added the backport 2.x Backport to 2.x branch label Sep 13, 2023
@sohami sohami merged commit 8b1ab23 into opensearch-project:main Sep 13, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 13, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
Parameterize tests for concurrent search 2 (#9852)
5e3da0e 
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
(cherry picked from commit 8b1ab23)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request Sep 14, 2023
@opensearch-trigger-bot @github-actions
Parameterize tests for concurrent search 2 (#9852) (#10034)
26203c2 
(cherry picked from commit 8b1ab23)

Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
@neetikasinghal @sarthakaggarwal97
Parameterize tests for concurrent search 2 (opensearch-project#9852)
566e404 
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@neetikasinghal @brusic
Parameterize tests for concurrent search 2 (opensearch-project#9852)
6dd5a71 
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
@neetikasinghal @vikasvb90
Parameterize tests for concurrent search 2 (opensearch-project#9852)
632280a 
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@neetikasinghal @shiv0408
Parameterize tests for concurrent search 2 (opensearch-project#9852)
26b1a3e 
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohami sohami sohami approved these changes

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameterize Search ITs to run with Concurrent Search Feature enabled.
3 participants
@neetikasinghal @reta @sohami