Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable shard/segment level search_after short cutting if track_total_hits != false (#9683) #9716

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

gashutos
Copy link
Contributor

@gashutos gashutos commented Sep 3, 2023

Bckport of #9683

…_hits != false (opensearch-project#9683)

Signed-off-by: gashutos <gashutos@amazon.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Compatibility status:

Checks if related components are compatible with change 4eed2bf

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsOnRemoteStoreRestore

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #9716 (4eed2bf) into 2.x (58ae69d) will increase coverage by 0.06%.
Report is 2 commits behind head on 2.x.
The diff coverage is 75.82%.

@@             Coverage Diff              @@
##                2.x    #9716      +/-   ##
============================================
+ Coverage     70.80%   70.86%   +0.06%     
- Complexity    57868    57941      +73     
============================================
  Files          4793     4794       +1     
  Lines        273397   273455      +58     
  Branches      40216    40227      +11     
============================================
+ Hits         193583   193796     +213     
+ Misses        63235    63112     -123     
+ Partials      16579    16547      -32     
Files Changed Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 93.18% <ø> (ø)
...opensearch/index/SegmentReplicationShardStats.java 39.13% <40.00%> (+0.10%) ⬆️
...replication/common/SegmentReplicationLagTimer.java 40.00% <40.00%> (ø)
...main/java/org/opensearch/search/SearchService.java 71.80% <60.00%> (+0.10%) ⬆️
...earch/index/SegmentReplicationPressureService.java 76.69% <69.23%> (-0.63%) ⬇️
.../replication/checkpoint/ReplicationCheckpoint.java 84.61% <72.72%> (-3.11%) ⬇️
...org/opensearch/index/seqno/ReplicationTracker.java 68.42% <84.61%> (-0.04%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 68.97% <100.00%> (+0.31%) ⬆️
...x/store/remote/metadata/RemoteSegmentMetadata.java 100.00% <100.00%> (ø)
...ckpoint/SegmentReplicationCheckpointPublisher.java 100.00% <100.00%> (ø)
... and 2 more

... and 457 files with indirect coverage changes

@gashutos
Copy link
Contributor Author

gashutos commented Sep 4, 2023

@reta can you help merging this ?

@gashutos
Copy link
Contributor Author

gashutos commented Sep 5, 2023

@sachinpkale help merging this ?

@sachinpkale sachinpkale merged commit 36b6cf8 into opensearch-project:2.x Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants