Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding broken links checker #877

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Adding broken links checker #877

merged 4 commits into from
Jul 12, 2021

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Adding a broken links checker github action to check for broken links on PRs and push.

Issues Resolved

#873

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success f39c54aae4ee4f7be4c1ba486e2c155696aae267

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed f39c54aae4ee4f7be4c1ba486e2c155696aae267

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success f39c54aae4ee4f7be4c1ba486e2c155696aae267

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 2b90cdae0b496745e6283be54db8078e41db4f62

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 2b90cdae0b496745e6283be54db8078e41db4f62

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 2b90cdae0b496745e6283be54db8078e41db4f62

@VachaShah
Adding broken links checker
826ec53 
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah force-pushed the add_broken_links_checker branch from 2b90cda to 826ec53 Compare June 25, 2021 00:39
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 826ec53

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 826ec53

@VachaShah
Copy link
Collaborator Author

VachaShah commented Jun 25, 2021 •
edited
Loading

Broken links found in the link checker. I will be working on fixing those.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 826ec53

@nknize nknize added CI CI related Build Libraries & Interfaces non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues labels Jun 25, 2021
@VachaShah VachaShah mentioned this pull request Jun 28, 2021
Closed
34 tasks
@saratvemulapalli
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 826ec53
Log 299

Reports 299

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 826ec53

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 826ec53

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 826ec53

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 7c8733a9f5407d985db0085cb3c5bf9f08e08adb

@VachaShah VachaShah force-pushed the add_broken_links_checker branch from 7c8733a to 78ecbc3 Compare July 8, 2021 18:53
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 78ecbc380c36bee6acf1798e25625f9d0874b66c

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 78ecbc380c36bee6acf1798e25625f9d0874b66c

@VachaShah
Adding exclusions for links
682c63c 
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah force-pushed the add_broken_links_checker branch from 78ecbc3 to 682c63c Compare July 8, 2021 18:56
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 682c63c

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 682c63c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 78ecbc380c36bee6acf1798e25625f9d0874b66c

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 682c63c

@dblock
Copy link
Member

dblock commented Jul 8, 2021

It found some real issues! Let's fix them as part of this CR.

@dblock dblock mentioned this pull request Jul 8, 2021
Merged
5 tasks
@VachaShah
Copy link
Collaborator Author

It found some real issues! Let's fix them as part of this CR.

Yes I have created a Meta issue for all the broken links: #894 and am working on fixing them.

@VachaShah
Correcting broken link
0502777 
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 0502777

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 0502777

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 0502777

@VachaShah
Removing the benchmarks link
a74a33f 
Signed-off-by: Vacha Shah <vachshah@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success a74a33f

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed a74a33f

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success a74a33f

@saratvemulapalli
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success a74a33f
Log 328

Reports 328

@saratvemulapalli
Copy link
Member

Thanks @VachaShah for taking care of this!

@saratvemulapalli saratvemulapalli merged commit e17ce53 into opensearch-project:main Jul 12, 2021
@VachaShah VachaShah deleted the add_broken_links_checker branch July 12, 2021 21:24
@cliu123 cliu123 mentioned this pull request Jul 13, 2021
Closed
@kavilla kavilla mentioned this pull request Jul 13, 2021
Closed
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
@VachaShah
Fix integer overflow for remaining index stats (opensearch-project#877)
0c88a6a 
* Fix integer overflow for remaining index stats

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Adding changelog

Signed-off-by: Vacha Shah <vachshah@amazon.com>

---------

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

Assignees
No one assigned
Labels
Build Libraries & Interfaces CI CI related non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VachaShah @opensearch-ci-bot @saratvemulapalli @dblock @nknize