Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tracer injectable #8696

Merged
merged 5 commits into from
Jul 19, 2023
Merged

Conversation

suranjay
Copy link
Contributor

@suranjay suranjay commented Jul 14, 2023

Description

As a follow-up of this PR, this change makes Tracer.java injectable instead of TracerFactory.java

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
@suranjay
Copy link
Contributor Author

@reta Please review

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

CHANGELOG.md Outdated Show resolved Hide resolved
@reta
Copy link
Collaborator

reta commented Jul 14, 2023

@reta Please review

LGTM, please fix changelog and I think we are good to go, the test failure are unrelated: #8699

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member

Test failure fixed by #8704. @suranjay can you please rebase this PR?

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.index.IndexSettingsTests.testDefaultSearchPipelineWithoutFeatureFlag

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #8696 (5b355ed) into main (57d5e90) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8696      +/-   ##
============================================
+ Coverage     70.76%   71.38%   +0.61%     
- Complexity    57111    57519     +408     
============================================
  Files          4771     4771              
  Lines        270241   270242       +1     
  Branches      39500    39500              
============================================
+ Hits         191237   192911    +1674     
+ Misses        62846    61369    -1477     
+ Partials      16158    15962     -196     
Impacted Files Coverage Δ
server/src/main/java/org/opensearch/node/Node.java 86.04% <100.00%> (+0.01%) ⬆️

... and 487 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.index.IndexSettingsTests.testDefaultSearchPipelineWithoutFeatureFlag

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testCancellation
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.index.IndexSettingsTests.testDefaultSearchPipelineWithoutFeatureFlag

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollCreatedOnReplica
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@suranjay
Copy link
Contributor Author

@andrross Please review/approve the PR, all failing tests have been fixed

@andrross andrross merged commit 83a4b6e into opensearch-project:main Jul 19, 2023
@andrross andrross added the backport 2.x Backport to 2.x branch label Jul 19, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2023
* Make Tracer injectable

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Add changelog entry

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Remove entry from CHANGELOG.md

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

---------

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
(cherry picked from commit 83a4b6e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jul 19, 2023
* Make Tracer injectable



* Add changelog entry



* Remove entry from CHANGELOG.md



---------


(cherry picked from commit 83a4b6e)

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
* Make Tracer injectable

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Add changelog entry

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Remove entry from CHANGELOG.md

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

---------

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
* Make Tracer injectable

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Add changelog entry

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Remove entry from CHANGELOG.md

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

---------

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Make Tracer injectable

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Add changelog entry

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

* Remove entry from CHANGELOG.md

Signed-off-by: suranjay <surajkumar.tu@gmail.com>

---------

Signed-off-by: suranjay <surajkumar.tu@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants