-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Tracer injectable #8696
Merged
Merged
Make Tracer injectable #8696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
suranjay
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 14, 2023 15:35
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
@reta Please review |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Jul 14, 2023
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: suranjay <surajkumar.tu@gmail.com>
suranjay
force-pushed
the
tracer_injection
branch
from
July 18, 2023 05:35
42120c7
to
aa694a1
Compare
Gradle Check (Jenkins) Run Completed with:
|
suranjay
force-pushed
the
tracer_injection
branch
from
July 18, 2023 05:42
b193e98
to
a81d568
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8696 +/- ##
============================================
+ Coverage 70.76% 71.38% +0.61%
- Complexity 57111 57519 +408
============================================
Files 4771 4771
Lines 270241 270242 +1
Branches 39500 39500
============================================
+ Hits 191237 192911 +1674
+ Misses 62846 61369 -1477
+ Partials 16158 15962 -196
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@andrross Please review/approve the PR, all failing tests have been fixed |
andrross
approved these changes
Jul 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Make Tracer injectable Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Remove entry from CHANGELOG.md Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com> (cherry picked from commit 83a4b6e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Make Tracer injectable * Add changelog entry * Remove entry from CHANGELOG.md --------- (cherry picked from commit 83a4b6e) Signed-off-by: suranjay <surajkumar.tu@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
* Make Tracer injectable Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Remove entry from CHANGELOG.md Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
* Make Tracer injectable Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Remove entry from CHANGELOG.md Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Make Tracer injectable Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Add changelog entry Signed-off-by: suranjay <surajkumar.tu@gmail.com> * Remove entry from CHANGELOG.md Signed-off-by: suranjay <surajkumar.tu@gmail.com> --------- Signed-off-by: suranjay <surajkumar.tu@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow-up of this PR, this change makes
Tracer.java
injectable instead ofTracerFactory.java
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.