CardinalityIT/NestedIT test failures with concurrent search enabled and AssertingCodec

[sohami]

Description

Backport of #8303

Related Issues

Resolves #8095

Check List

• New functionality includes testing.
  • All tests pass
• [] New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPrimaryStopped_ReplicaPromoted
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

• URL: https://build.ci.opensearch.org/job/gradle-check/20145/
• CommitID: 6355800
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #8687 (6355800) into 2.x (90d1da2) will decrease coverage by 0.02%.
The diff coverage is 67.34%.

@@             Coverage Diff              @@
##                2.x    #8687      +/-   ##
============================================
- Coverage     70.61%   70.60%   -0.02%     
- Complexity    57254    57308      +54     
============================================
  Files          4756     4757       +1     
  Lines        271489   271521      +32     
  Branches      40019    40025       +6     
============================================
- Hits         191710   191701       -9     
- Misses        63340    63394      +54     
+ Partials      16439    16426      -13     

Impacted Files	Coverage Δ
...nsearch/search/internal/FilteredSearchContext.java	8.92% <0.00%> (-0.25%)	⬇️
...arch/aggregations/DefaultAggregationProcessor.java	13.95% <50.00%> (+1.75%)	⬆️
.../search/aggregations/BucketCollectorProcessor.java	65.62% <65.62%> (ø)
.../org/opensearch/search/internal/SearchContext.java	38.00% <66.66%> (+1.82%)	⬆️
...va/org/opensearch/search/DefaultSearchContext.java	78.90% <100.00%> (+0.33%)	⬆️
...arch/aggregations/AggregationCollectorManager.java	83.33% <100.00%> (+10.00%)	⬆️
...h/aggregations/ConcurrentAggregationProcessor.java	81.25% <100.00%> (+1.25%)	⬆️
...ensearch/search/internal/ContextIndexSearcher.java	68.23% <100.00%> (+0.18%)	⬆️

... and 429 files with indirect coverage changes

[sohami]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPrimaryStopped_ReplicaPromoted
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

• URL: https://build.ci.opensearch.org/job/gradle-check/20145/
• CommitID: 6355800
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

unrelated failures.

[kotwanikunal]

@sohami / @reta Code coverage does not meet the threshold. I think we need more UTs.

[sohami]

@sohami / @reta Code coverage does not meet the threshold. I think we need more UTs.

@kotwanikunal The change is fixing the IT test listed in the title so the coverage is there with ITs and it will also execute for each of the aggregation search path which has extensive coverage

[kotwanikunal]

@sohami / @reta Code coverage does not meet the threshold. I think we need more UTs.

@kotwanikunal The change is fixing the IT test listed in the title so the coverage is there with ITs and it will also execute for each of the aggregation search path which has extensive coverage

Ahh. Never realized ITs were not only not covered in codecov but are also considered as code. 💯