Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Removed unused extension directory #8674

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

owaiskazi19
Copy link
Member

Description

Removed unused extension directory

Related Issues

Resolves #8563

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 force-pushed the remove-extension-dir branch from 75ad4a9 to f11a318 Compare July 13, 2023 00:14
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #8674 (f11a318) into main (6a35ffa) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8674      +/-   ##
============================================
- Coverage     70.91%   70.82%   -0.09%     
- Complexity    57093    57112      +19     
============================================
  Files          4770     4770              
  Lines        270199   270199              
  Branches      39496    39496              
============================================
- Hits         191604   191371     -233     
- Misses        62371    62720     +349     
+ Partials      16224    16108     -116     

see 464 files with indirect coverage changes

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbwiddis
Copy link
Member

This should be backported to 2.x and 2.9, I think?

@owaiskazi19
Copy link
Member Author

owaiskazi19 commented Jul 13, 2023

Please also remove this line:

https://github.com/saratvemulapalli/OpenSearch/blob/78dd198c9f0e4bfd603be1f79946bf2ff8ddd421/server/src/main/java/org/opensearch/bootstrap/Security.java#L319

I think you pulled Sarat's repo. The directory is not present on main.

@owaiskazi19 owaiskazi19 added backport 2.x Backport to 2.x branch backport 2.9 Backport to 2.9 branch labels Jul 13, 2023
@dbwiddis
Copy link
Member

Please also remove this line:
https://github.com/saratvemulapalli/OpenSearch/blob/78dd198c9f0e4bfd603be1f79946bf2ff8ddd421/server/src/main/java/org/opensearch/bootstrap/Security.java#L319

I think you pulled Sarat's repo. The directory is not present on main.

Ah, got it, so #8563 was already "fixed" and the bug was against 2.8.

@dbwiddis dbwiddis merged commit ab68d3e into opensearch-project:main Jul 13, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8674-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab68d3e0742e43837f5754e9e7784ead95f37643
# Push it to GitHub
git push --set-upstream origin backport/backport-8674-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8674-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-8674-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab68d3e0742e43837f5754e9e7784ead95f37643
# Push it to GitHub
git push --set-upstream origin backport/backport-8674-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-8674-to-2.9.

@owaiskazi19 owaiskazi19 removed the backport 2.9 Backport to 2.9 branch label Jul 13, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] opensearch attempts to create a directory in path.home (and fails)
4 participants