-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extensions] Removed unused extension directory #8674
[Extensions] Removed unused extension directory #8674
Conversation
721d54e
to
75ad4a9
Compare
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
75ad4a9
to
f11a318
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8674 +/- ##
============================================
- Coverage 70.91% 70.82% -0.09%
- Complexity 57093 57112 +19
============================================
Files 4770 4770
Lines 270199 270199
Branches 39496 39496
============================================
- Hits 191604 191371 -233
- Misses 62371 62720 +349
+ Partials 16224 16108 -116 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be backported to 2.x and 2.9, I think? |
I think you pulled Sarat's repo. The directory is not present on main. |
Ah, got it, so #8563 was already "fixed" and the bug was against 2.8. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8674-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab68d3e0742e43837f5754e9e7784ead95f37643
# Push it to GitHub
git push --set-upstream origin backport/backport-8674-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-8674-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ab68d3e0742e43837f5754e9e7784ead95f37643
# Push it to GitHub
git push --set-upstream origin backport/backport-8674-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.9 Then, create a pull request where the |
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Removed unused extension directory
Related Issues
Resolves #8563
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.