Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] HPPC IntArrayList and ObjectArrayList to j.u.List #8602

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 10, 2023

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to java.util.List.

relates #5910

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication
      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithoutInvokeFlush
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithoutInvokeFlush
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #8602 (b2edd6b) into main (2004ba0) will decrease coverage by 0.04%.
The diff coverage is 77.27%.

❗ Current head b2edd6b differs from pull request most recent head 3cf3d7a. Consider uploading reports for the commit 3cf3d7a to get more accurate results

@@             Coverage Diff              @@
##               main    #8602      +/-   ##
============================================
- Coverage     70.90%   70.87%   -0.04%     
+ Complexity    57008    56915      -93     
============================================
  Files          4759     4758       -1     
  Lines        269693   269227     -466     
  Branches      39454    39402      -52     
============================================
- Hits         191235   190807     -428     
+ Misses        62317    62300      -17     
+ Partials      16141    16120      -21     
Impacted Files Coverage Δ
...g/opensearch/action/get/MultiGetShardResponse.java 0.00% <0.00%> (ø)
...ion/termvectors/MultiTermVectorsShardResponse.java 0.00% <0.00%> (ø)
...ensearch/search/fetch/ShardFetchSearchRequest.java 77.77% <ø> (ø)
...tion/termvectors/MultiTermVectorsShardRequest.java 30.30% <50.00%> (ø)
...rg/opensearch/action/get/MultiGetShardRequest.java 82.60% <100.00%> (ø)
...org/opensearch/action/search/FetchSearchPhase.java 86.73% <100.00%> (ø)
...pensearch/action/search/SearchPhaseController.java 81.81% <100.00%> (-1.71%) ⬇️
.../search/SearchScrollQueryThenFetchAsyncAction.java 85.41% <100.00%> (ø)
...va/org/opensearch/common/transport/PortsRange.java 87.09% <100.00%> (ø)
...org/opensearch/search/fetch/ShardFetchRequest.java 83.33% <100.00%> (ø)

... and 568 files with indirect coverage changes

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There's a conflict on the changelog. I'd be fine with omitting a changelog entry here since this is really just an internal refactoring.

@nknize nknize force-pushed the intArrayListToJavaArrayList branch from b2edd6b to a664b37 Compare July 11, 2023 15:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the intArrayListToJavaArrayList branch from a664b37 to 3cf3d7a Compare July 11, 2023 19:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize merged commit 8d2ec76 into opensearch-project:main Jul 11, 2023
@nknize nknize added the pending backport Identifies an issue or PR that still needs to be backported label Jul 11, 2023
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…rch-project#8602)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…rch-project#8602)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added backport 2.x Backport to 2.x branch and removed pending backport Identifies an issue or PR that still needs to be backported labels Jul 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2023
Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 8d2ec76)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 12, 2023
…8661)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.


(cherry picked from commit 8d2ec76)

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
…rch-project#8602)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…rch-project#8602)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…rch-project#8602)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…rch-project#8602)

Refactors usage of obsolete HPPC IntArrayList and ObjectArrayList to
java.util.List.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants