Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shard id to remote store logs #8574

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Jul 10, 2023

Description

Adds shard id to remote store related logs

Related Issues

Resolves #7921

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@linuxpi linuxpi force-pushed the remote-store-logs-shard-id branch from 88c5342 to f0babbf Compare July 10, 2023 13:36
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the remote-store-logs-shard-id branch 2 times, most recently from 53b6909 to 20c34b9 Compare July 10, 2023 15:49
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: bansvaru <bansvaru@amazon.com>
@linuxpi linuxpi force-pushed the remote-store-logs-shard-id branch from 19cc676 to 9f7ae9e Compare July 11, 2023 08:01
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the remote-store-logs-shard-id branch from 6fcf79f to e5ff506 Compare July 11, 2023 09:10
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: bansvaru <bansvaru@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush

@linuxpi linuxpi force-pushed the remote-store-logs-shard-id branch from e5ff506 to 67d8c2f Compare July 11, 2023 09:51
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #8574 (e5ff506) into main (418ab51) will increase coverage by 0.13%.
The diff coverage is 54.54%.

❗ Current head e5ff506 differs from pull request most recent head 67d8c2f. Consider uploading reports for the commit 67d8c2f to get more accurate results

@@             Coverage Diff              @@
##               main    #8574      +/-   ##
============================================
+ Coverage     70.85%   70.99%   +0.13%     
- Complexity    56948    56991      +43     
============================================
  Files          4758     4758              
  Lines        269382   269386       +4     
  Branches      39414    39414              
============================================
+ Hits         190877   191241     +364     
+ Misses        62429    62044     -385     
- Partials      16076    16101      +25     
Impacted Files Coverage Δ
...rg/opensearch/index/translog/RemoteFsTranslog.java 69.78% <38.46%> (-0.62%) ⬇️
...dex/translog/transfer/TranslogTransferManager.java 73.63% <66.66%> (-0.50%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 69.90% <100.00%> (+0.69%) ⬆️
...search/index/shard/RemoteStoreRefreshListener.java 83.49% <100.00%> (-2.36%) ⬇️

... and 468 files with indirect coverage changes

Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@linuxpi
Copy link
Collaborator Author

linuxpi commented Jul 11, 2023

precommit is showing failed for windows-latest but if you open details then the precommit build has passed. Also the macos precommit is passed

@sachinpkale sachinpkale merged commit 8a831f8 into opensearch-project:main Jul 11, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 11, 2023
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit 8a831f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Jul 11, 2023
---------


(cherry picked from commit 8a831f8)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@linuxpi linuxpi deleted the remote-store-logs-shard-id branch July 11, 2023 13:18
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
---------

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote Store] Prefix logs with index and shard information
4 participants