-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump schema validator from from 1.0.85 to 1.0.86 #8573
Bump schema validator from from 1.0.85 to 1.0.86 #8573
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
e66d867
to
cb27e28
Compare
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Failure seems to be a jenkins issue not related to this change. Also happening here: https://github.com/opensearch-project/OpenSearch/actions/runs/5508946707/jobs/10040944804?pr=8576 |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #8573 +/- ##
============================================
+ Coverage 70.85% 70.91% +0.05%
- Complexity 56948 56967 +19
============================================
Files 4758 4758
Lines 269382 269382
Branches 39414 39414
============================================
+ Hits 190877 191031 +154
+ Misses 62429 62297 -132
+ Partials 16076 16054 -22
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Gradle Check (Jenkins) Run Completed with:
|
@@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
- Bump `org.bouncycastle:bcprov-jdk15on` to `org.bouncycastle:bcprov-jdk15to18` version 1.75 ([#8247](https://github.com/opensearch-project/OpenSearch/pull/8247)) | |||
- Bump `org.bouncycastle:bcmail-jdk15on` to `org.bouncycastle:bcmail-jdk15to18` version 1.75 ([#8247](https://github.com/opensearch-project/OpenSearch/pull/8247)) | |||
- Bump `org.bouncycastle:bcpkix-jdk15on` to `org.bouncycastle:bcpkix-jdk15to18` version 1.75 ([#8247](https://github.com/opensearch-project/OpenSearch/pull/8247)) | |||
- Bump `com.networknt:json-schema-validator` from 1.0.85 to 1.0.86 ([#8573](https://github.com/opensearch-project/OpenSearch/pull/8573)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Generally we add the changelog at the last
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged too early. This change needs to be in Unreleased 2.x section since we will backport it to 2.x @scrawfor99 can you take care of this? Thanks
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8573-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 71f807329a92f05012924348de0b5d8884023bd0
# Push it to GitHub
git push --set-upstream origin backport/backport-8573-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* Manual backports Signed-off-by: Stephen Crawford <steecraw@amazon.com> * remove blank lines Signed-off-by: Stephen Crawford <steecraw@amazon.com> * fix numbers Signed-off-by: Stephen Crawford <steecraw@amazon.com> * fix numbering Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
…8573) * Bump schema validator Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Manually trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Make trivial change to trigger rerun Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
…8573) * Bump schema validator Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Manually trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Make trivial change to trigger rerun Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
…8573) * Bump schema validator Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Manually trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Make trivial change to trigger rerun Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
…8573) * Bump schema validator Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Manually trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Make trivial change to trigger rerun Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…8573) * Bump schema validator Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Manually trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Make trivial change to trigger rerun Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
…8573) * Bump schema validator Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update changelog Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Manually trigger retry Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Make trivial change to trigger rerun Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Manually bump schema validator since #8570 failed.
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.