-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Add logic back to update tracking replication checkpoint on source #8560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heckpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 9, 2023 22:32
mch2
reviewed
Jul 9, 2023
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationSourceHandler.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
mch2
reviewed
Jul 10, 2023
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationSourceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
commented
Jul 10, 2023
qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
… update Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
mch2
approved these changes
Jul 11, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8560-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d7d33bdbc02ec8e363c5394a9d89451f76e979a
# Push it to GitHub
git push --set-upstream origin backport/backport-8560-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
dreamer-89
added a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Jul 11, 2023
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit 3d7d33b)
dreamer-89
added a commit
that referenced
this pull request
Jul 11, 2023
…heckpoint on source (#8560) (#8633) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit 3d7d33b)
vikasvb90
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
raghuvanshraj
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
dzane17
pushed a commit
to dzane17/OpenSearch
that referenced
this pull request
Jul 12, 2023
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
6 tasks
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…heckpoint on source (opensearch-project#8560) * [Segment Replication] Add logic back to update tracking replication checkpoint on source Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update comment Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments & mute breaking bwc-test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> * Stop timer inside try to prevent double stop on timer Signed-off-by: Suraj Singh <surajrider@gmail.com> * Update PressureITs to wait for appropriate transport call for replica update Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #8020, the behavior around how primary tracks replica checkpoint was changed. The change was to rely on replica shard initiating a separate transport call to primary for checkpoint update when segment replication round finishes. This additional network call breaks backward compatibility with released versions where source does not have respective transport handler to update target replication checkpoint and fails with below error
This PR now allows the primary to update the visible ReplicationCheckpoint of replica shards with node-node communication. In current state:
get_segment_files
handlingupdate_visible_checkpoint
transport call.Related Issues
Resolves #8322
Related: #8202
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.