-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating default compression level for ZStandard Codecs #8471
Merged
shwetathareja
merged 1 commit into
opensearch-project:main
from
sarthakaggarwal97:change-zstd-def-compression-level
Jul 6, 2023
Merged
Updating default compression level for ZStandard Codecs #8471
shwetathareja
merged 1 commit into
opensearch-project:main
from
sarthakaggarwal97:change-zstd-def-compression-level
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakaggarwal97
force-pushed
the
change-zstd-def-compression-level
branch
from
July 6, 2023 06:34
47c99eb
to
904a7b1
Compare
Gradle Check (Jenkins) Run Completed with:
|
sarthakaggarwal97
changed the title
default compression level change
Updating default compression level for ZSTD
Jul 6, 2023
sarthakaggarwal97
changed the title
Updating default compression level for ZSTD
Updating default compression level for ZStandard Codecs
Jul 6, 2023
sarthakaggarwal97
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 6, 2023 06:47
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
change-zstd-def-compression-level
branch
from
July 6, 2023 06:55
904a7b1
to
6dde2cc
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8471 +/- ##
============================================
+ Coverage 70.84% 70.94% +0.09%
- Complexity 56935 56954 +19
============================================
Files 4758 4758
Lines 269219 269219
Branches 39407 39407
============================================
+ Hits 190740 191007 +267
+ Misses 62416 62126 -290
- Partials 16063 16086 +23
|
shwetathareja
approved these changes
Jul 6, 2023
backslasht
approved these changes
Jul 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit eca5a6c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit eca5a6c)
6 tasks
shwetathareja
pushed a commit
that referenced
this pull request
Jul 6, 2023
vikasvb90
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
raghuvanshraj
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to update the default ZStandard compression level to 3 based on the performance gains we are observing over here at #7555
Related Issues
Resolves:
Optimization mentioned at #7555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.