-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Segment Store] Make metadata file immutable #8363
Merged
gbbafna
merged 12 commits into
opensearch-project:main
from
sachinpkale:new-metadata-integration
Jul 6, 2023
Merged
[Remote Segment Store] Make metadata file immutable #8363
gbbafna
merged 12 commits into
opensearch-project:main
from
sachinpkale:new-metadata-integration
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
force-pushed
the
new-metadata-integration
branch
from
July 1, 2023 13:44
9e8bcf8
to
018f7d0
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
commented
Jul 2, 2023
plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3BlobContainer.java
Outdated
Show resolved
Hide resolved
sachinpkale
commented
Jul 2, 2023
...ns/repository-s3/src/test/java/org/opensearch/repositories/s3/S3BlobStoreContainerTests.java
Outdated
Show resolved
Hide resolved
sachinpkale
commented
Jul 2, 2023
qa/mixed-cluster/src/test/java/org/opensearch/backwards/IndexingIT.java
Outdated
Show resolved
Hide resolved
sachinpkale
commented
Jul 2, 2023
server/src/main/java/org/opensearch/common/blobstore/BlobContainer.java
Outdated
Show resolved
Hide resolved
sachinpkale
commented
Jul 2, 2023
server/src/test/java/org/opensearch/common/blobstore/fs/FsBlobContainerTests.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Tagging @harishbhakuni21 to review changes to snapshot interoperability logic as part of this PR. |
sachinpkale
changed the title
[Remote Segment Store] New immutable metadata integration in RemoteSegmentStoreDirectory
[Remote Segment Store] Make metadata file immutable
Jul 2, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8363 +/- ##
============================================
+ Coverage 70.87% 70.93% +0.06%
- Complexity 56923 56944 +21
============================================
Files 4758 4758
Lines 269219 269221 +2
Branches 39407 39402 -5
============================================
+ Hits 190800 190963 +163
+ Misses 62352 62107 -245
- Partials 16067 16151 +84
|
sachinpkale
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE and
dblock
as code owners
July 3, 2023 01:34
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
force-pushed
the
new-metadata-integration
branch
from
July 6, 2023 08:37
1213cc9
to
e0823f1
Compare
gbbafna
reviewed
Jul 6, 2023
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
gbbafna
reviewed
Jul 6, 2023
server/src/test/java/org/opensearch/index/store/RemoteSegmentStoreDirectoryTests.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
approved these changes
Jul 6, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8363-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5c0e3c94950796f7c99a20456528181ae9f16bbf
# Push it to GitHub
git push --set-upstream origin backport/backport-8363-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 8, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 8, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 10, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 11, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com>
sachinpkale
added a commit
to sachinpkale/OpenSearch
that referenced
this pull request
Jul 11, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com>
vikasvb90
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com>
raghuvanshraj
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com>
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ct#8363) Authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long.MAX_VALUE - original number
padded with 0s at the front to make the length consistent with that ofLong.MAX_VALUE
.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.