-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote translog] Make translog buffer interval setting dynamic #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8175 +/- ##
============================================
+ Coverage 70.92% 71.01% +0.08%
- Complexity 56664 56726 +62
============================================
Files 4722 4722
Lines 267604 267597 -7
Branches 39214 39212 -2
============================================
+ Hits 189803 190036 +233
+ Misses 61826 61585 -241
- Partials 15975 15976 +1
|
ef9d05a
to
ccd6348
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
Jun 21, 2023
sachinpkale
reviewed
Jun 21, 2023
server/src/main/java/org/opensearch/common/settings/IndexScopedSettings.java
Show resolved
Hide resolved
sachinpkale
approved these changes
Jun 22, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8175-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3305c771bd5b85c4122e4ff1aa76af71b5c8160a
# Push it to GitHub
git push --set-upstream origin backport/backport-8175-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Will raise manual backport. |
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
sudarshan-baliga
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Jun 29, 2023
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Jul 3, 2023
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com>
6 tasks
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Jul 3, 2023
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Jul 3, 2023
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
Jul 4, 2023
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com>
sachinpkale
pushed a commit
that referenced
this pull request
Jul 4, 2023
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ch-project#8175) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
skip-changelog
Storage:Durability
Issues and PRs related to the durability framework
v2.9.0
'Issues and PRs related to version v2.9.0'
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to make the remote translog upload buffer interval setting dynamic to allow changes even after index creation.
Related Issues
Resolves #8172
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.