Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote translog] Make translog buffer interval setting dynamic #8175

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jun 20, 2023

Description

This PR attempts to make the remote translog upload buffer interval setting dynamic to allow changes even after index creation.

Related Issues

Resolves #8172

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #8175 (d100af1) into main (0b775e7) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8175      +/-   ##
============================================
+ Coverage     70.92%   71.01%   +0.08%     
- Complexity    56664    56726      +62     
============================================
  Files          4722     4722              
  Lines        267604   267597       -7     
  Branches      39214    39212       -2     
============================================
+ Hits         189803   190036     +233     
+ Misses        61826    61585     -241     
- Partials      15975    15976       +1     
Impacted Files Coverage Δ
...org/opensearch/cluster/metadata/IndexMetadata.java 85.86% <ø> (+0.60%) ⬆️
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...mmon/util/concurrent/BufferedAsyncIOProcessor.java 70.00% <100.00%> (+1.03%) ⬆️
.../main/java/org/opensearch/index/IndexSettings.java 86.18% <100.00%> (+0.17%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 70.73% <100.00%> (-0.12%) ⬇️

... and 486 files with indirect coverage changes

@ashking94 ashking94 self-assigned this Jun 20, 2023
@ashking94 ashking94 added Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0' skip-changelog labels Jun 20, 2023
@ashking94 ashking94 force-pushed the 8172 branch 3 times, most recently from ef9d05a to ccd6348 Compare June 20, 2023 18:47
@ashking94 ashking94 marked this pull request as ready for review June 20, 2023 18:47
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu

@sachinpkale sachinpkale merged commit 3305c77 into opensearch-project:main Jun 22, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jun 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8175-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3305c771bd5b85c4122e4ff1aa76af71b5c8160a
# Push it to GitHub
git push --set-upstream origin backport/backport-8175-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8175-to-2.x.

@ashking94
Copy link
Member Author

Will raise manual backport.

imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
…ch-project#8175)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
sudarshan-baliga pushed a commit to Gaurav614/OpenSearch that referenced this pull request Jun 29, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Jul 3, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Jul 3, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Jul 3, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Jul 4, 2023
sachinpkale pushed a commit that referenced this pull request Jul 4, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ch-project#8175)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote Translog] Make index.remote_store.translog.buffer_interval setting dynamic
3 participants