Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Manual] Added insecureString options to allow to easier migration (#5496) #8094

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

kartg
Copy link
Member

@kartg kartg commented Jun 16, 2023

Description

Manual backport of #5496 to 2.x

Signed-off-by: Chris White chriswhite199@gmail.com
(cherry picked from commit 0b775e7)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…-project#5496)

Signed-off-by: Chris White <chriswhite199@gmail.com>
(cherry picked from commit 0b775e7)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member

#1703 is back :(

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #8094 (97fe1f1) into 2.x (a8420a2) will decrease coverage by 0.02%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##                2.x    #8094      +/-   ##
============================================
- Coverage     70.66%   70.64%   -0.02%     
+ Complexity    56822    56800      -22     
============================================
  Files          4702     4702              
  Lines        268992   269002      +10     
  Branches      39767    39769       +2     
============================================
- Hits         190078   190032      -46     
- Misses        62533    62629      +96     
+ Partials      16381    16341      -40     
Impacted Files Coverage Δ
.../org/opensearch/common/settings/SecureSetting.java 74.62% <84.61%> (+9.71%) ⬆️

... and 479 files with indirect coverage changes

@kartg kartg merged commit 6ad4c4d into opensearch-project:2.x Jun 16, 2023
@kartg kartg deleted the backport/backport-5496-to-2.x branch June 20, 2023 19:59
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…-project#5496) (opensearch-project#8094)

Signed-off-by: Chris White <chriswhite199@gmail.com>
(cherry picked from commit 0b775e7)

Co-authored-by: Chris White <chriswhite199@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants