Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] TokenManager Interface #7927

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[Backport 2.x] TokenManager Interface #7927

merged 1 commit into from
Jun 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6fdeae9 from #7452.

@github-actions @reta
Add TokenManager to IdentityPlugin (#7452)
1cefcb0 
Add TokenManager to IdentityPlugin

Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
(cherry picked from commit 6fdeae9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #7927 (1cefcb0) into 2.x (fcdd2b0) will decrease coverage by 0.08%.
The diff coverage is 76.71%.

@@             Coverage Diff              @@
##                2.x    #7927      +/-   ##
============================================
- Coverage     70.60%   70.52%   -0.08%     
- Complexity    56478    56487       +9     
============================================
  Files          4669     4671       +2     
  Lines        267760   267824      +64     
  Branches      39642    39645       +3     
============================================
- Hits         189057   188889     -168     
- Misses        62394    62683     +289     
+ Partials      16309    16252      -57
Impacted Files Coverage Δ
...opensearch/identity/tokens/RestTokenExtractor.java 0.00% <0.00%> (ø)
...g/opensearch/identity/shiro/ShiroTokenManager.java 65.11% <65.11%> (ø)
...org/opensearch/identity/noop/NoopTokenManager.java 66.66% <66.66%> (ø)
...opensearch/identity/shiro/ShiroIdentityPlugin.java 88.88% <100.00%> (+88.88%) ⬆️
...va/org/opensearch/identity/shiro/ShiroSubject.java 44.44% <100.00%> (ø)
.../java/org/opensearch/identity/IdentityService.java 100.00% <100.00%> (ø)
...g/opensearch/identity/noop/NoopIdentityPlugin.java 100.00% <100.00%> (ø)
...org/opensearch/identity/tokens/BasicAuthToken.java 87.50% <100.00%> (+4.16%) ⬆️
...rg/opensearch/identity/tokens/BearerAuthToken.java 100.00% <100.00%> (ø)

... and 481 files with indirect coverage changes

@dblock dblock merged commit 91c7305 into 2.x Jun 6, 2023
@github-actions github-actions bot deleted the backport/backport-7452-to-2.x branch June 6, 2023 19:48
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
@opensearch-trigger-bot @github-actions
@reta @gaiksaya
Add TokenManager to IdentityPlugin (opensearch-project#7452) (opensea…
6e2b76e 
…rch-project#7927)

Add TokenManager to IdentityPlugin

Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication




(cherry picked from commit 6fdeae9)

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbogan ryanbogan ryanbogan approved these changes

@dblock dblock dblock approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @ryanbogan